[jira] [Commented] (HBASE-21749) RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication

["Nihal Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747710#comment-16747710 ] 

Nihal Jain commented on HBASE-21749:
------------------------------------

Ping [~tianjingyun], [~apurtell], [~zghaobac].

> RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-21749
>                 URL: https://issues.apache.org/jira/browse/HBASE-21749
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication, UI
>    Affects Versions: 3.0.0, 2.1.0
>            Reporter: Nihal Jain
>            Assignee: Nihal Jain
>            Priority: Major
>         Attachments: HBASE-21749.master.001.patch
>
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because {{shipper.getCurrentPath()}} may return null.
> We should have a null check @ [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331] 
> {code:java}
>       Path currentPath = shipper.getCurrentPath();
>       try {
>         fileSize = getFileSize(currentPath);
>       } catch (IOException e) {
>         LOG.warn("Ignore the exception as the file size of HLog only affects the web ui", e);
>         fileSize = -1;
>       }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)