You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/02 11:24:00 UTC

[jira] [Commented] (THRIFT-4400) Visual Studio Compiler project should link runtime statically in release builds

    [ https://issues.apache.org/jira/browse/THRIFT-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275515#comment-16275515 ] 

ASF GitHub Bot commented on THRIFT-4400:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/1436

    THRIFT-4400 Visual Studio Compiler project should link runtime static…

    …ally in release builds
    
    Client: Compiler (general)
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-4400

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1436
    
----
commit c84154bd16a75c09ff99ec34a3a52c982fe2194e
Author: Jens Geyer <je...@apache.org>
Date:   2017-12-02T09:28:25Z

    THRIFT-4400 Visual Studio Compiler project should link runtime statically in release builds
    Client: Compiler (general)
    Patch: Jens Geyer

----


> Visual Studio Compiler project should link runtime statically in release builds
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-4400
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4400
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> The current setting is to use the MSVRRT DLLs which is ok for debug versions but can be an issue with release builds, when that particular runtime library version is not available on a system. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)