[jira] [Commented] (PROTON-988) pn_messenger_set_flags does not support new SASL flag correctly

["Andrew Stitcher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737257#comment-14737257 ] 

Andrew Stitcher commented on PROTON-988:
----------------------------------------

In looking at the code for on_messenger_set_flags() I can see that the error checking is wrong in that it won't allow both flags to be set instead returning PN_ARG_ERR. Is that what this bug report is referring  to?

However note that the design of this API (I'm not defending just explaining) seems to be to set all the flags needed at once. This seems reasonable to me as the flags should hardly ever need to be changed once set.

If you need to do anything complex you can read the flags back.

> pn_messenger_set_flags does not support new SASL flag correctly
> ---------------------------------------------------------------
>
>                 Key: PROTON-988
>                 URL: https://issues.apache.org/jira/browse/PROTON-988
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.10
>         Environment: All OS
>            Reporter: Clemens Vasters
>             Fix For: 0.10
>
>
> The new flag PN_FLAGS_ALLOW_INSECURE_MECHS cannot be set though pn_messenger_set_flags.
> Setting the other defined flag, PN_FLAGS_CHECK_ROUTES, causes the preset PN_FLAGS_ALLOW_INSECURE_MECHS to be irrecoverably overridden.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)