You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/09 13:10:19 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #1165: FINERACT-1047 Added integration test for Order by (audit trails)
thesmallstar opened a new pull request #1165:
URL: https://github.com/apache/fineract/pull/1165
## Description
The test works on the fact that if the orderBy value is not supported the server returns a 400 status code, hence we check if for all required orderBy value we get a status code 200.
This is also the required test for #1027 which was fixed without any integration test.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1165: FINERACT-1047 Added integration test for Order by (audit trails)
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1165:
URL: https://github.com/apache/fineract/pull/1165#issuecomment-656117969
this will have merge conflict with #1164 depending upon which is merged first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1165: FINERACT-1047 Added integration test for Order by (audit trails)
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1165:
URL: https://github.com/apache/fineract/pull/1165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1165: FINERACT-1047 Added integration test for Order by (audit trails)
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1165:
URL: https://github.com/apache/fineract/pull/1165#issuecomment-659429419
@vorburger sorry for the delay.
I have updated this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1165: FINERACT-1047 Added integration test for Order by (audit trails)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1165:
URL: https://github.com/apache/fineract/pull/1165#issuecomment-659024811
@thesmallstar will you rebase this and fix merge conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org