You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Lorin Beer (JIRA)" <ji...@apache.org> on 2013/09/03 19:19:51 UTC

[jira] [Assigned] (CB-4588) Documentation for notification.confirm should say to pass buttonLabels as Array

     [ https://issues.apache.org/jira/browse/CB-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lorin Beer reassigned CB-4588:
------------------------------

    Assignee: Lorin Beer  (was: Michael Brooks)
    
> Documentation for notification.confirm should say to pass buttonLabels as Array
> -------------------------------------------------------------------------------
>
>                 Key: CB-4588
>                 URL: https://issues.apache.org/jira/browse/CB-4588
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 2.9.0
>            Reporter: Peter
>            Assignee: Lorin Beer
>            Priority: Minor
>
> Compare navigator.notification.confirm and navigator.notification.prompt.
> Both APIs allow caller to specifiy *buttonLabels* as 4th parameter, but confirm expects a comma separated String and prompt expects an array. The parameter passing mechanism should be consistent for these similar APIs.
> It looks like the cordova.js is already handling the scenario, because it says:
> {code}
> console.log("Notification.confirm(string, function, string, string) is deprecated.  Use Notification.confirm(string, function, string, array).");
> {code}
> But the documentation for navigator.confirm is out-of-step with the code; it should be updated to say to pass Array, not String.
> Seems related to CB-1933

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira