You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 06:32:36 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #9258: ARROW-11313: [Rust] Fixed size_hint

jorgecarleitao opened a new pull request #9258:
URL: https://github.com/apache/arrow/pull/9258


   `size_hint` should return the remaining items, not the total number of items.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9258: ARROW-11313: [Rust] Fixed size_hint

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9258:
URL: https://github.com/apache/arrow/pull/9258#issuecomment-762641137


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=h1) Report
   > Merging [#9258](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=desc) (f76ceab) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9258/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9258   +/-   ##
   =======================================
     Coverage   81.61%   81.61%           
   =======================================
     Files         215      215           
     Lines       51867    51891   +24     
   =======================================
   + Hits        42329    42353   +24     
     Misses       9538     9538           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/array/iterator.rs](https://codecov.io/gh/apache/arrow/pull/9258/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvaXRlcmF0b3IucnM=) | `93.45% <100.00%> (ø)` | |
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9258/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `91.66% <100.00%> (+0.16%)` | :arrow_up: |
   | [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9258/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=footer). Last update [1401359...ac029f6](https://codecov.io/gh/apache/arrow/pull/9258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9258: ARROW-11313: [Rust] Fixed size_hint

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9258:
URL: https://github.com/apache/arrow/pull/9258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9258: ARROW-11313: [Rust] Fixed size_hint

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9258:
URL: https://github.com/apache/arrow/pull/9258#issuecomment-763091264


   I merged this branch locally and ran the tests and everything looked good 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9258: ARROW-11313: [Rust] Fixed size_hint

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9258:
URL: https://github.com/apache/arrow/pull/9258#issuecomment-762632757


   https://issues.apache.org/jira/browse/ARROW-11313


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org