You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/03 08:04:04 UTC
[jira] [Commented] (ARTEMIS-1043) NettyConnector not working with
IPv6 address
[ https://issues.apache.org/jira/browse/ARTEMIS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994442#comment-15994442 ]
ASF GitHub Bot commented on ARTEMIS-1043:
-----------------------------------------
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1245
[1.x] [ARTEMIS-1043] Support IPv6 in NettyConnector
Wrap the host added to the HTTP request headers with
IPV6Util.encloseHost to ensure that load balancers that reads the header
will have a valid IPv6 address.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1043
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-1043_NettyConnector_IPv6_1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1245
----
commit 64c89b6874a0c72df15397db779ecb817885be35
Author: Jeff Mesnil <jm...@gmail.com>
Date: 2017-05-03T07:56:24Z
[ARTEMIS-1043] Support IPv6 in NettyConnector
Wrap the host added to the HTTP request headers with
IPV6Util.encloseHost to ensure that load balancers that reads the header
will have a valid IPv6 address.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1043
----
> NettyConnector not working with IPv6 address
> --------------------------------------------
>
> Key: ARTEMIS-1043
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1043
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.3
> Reporter: Jeff Mesnil
> Fix For: 1.5.5, 2.next
>
>
> Artemis client doesn't correctly enclose IPv6 address when sending HTTP upgrade packet.
> According to [RFC2732 | https://www.ietf.org/rfc/rfc2732.txt], section {{2. Literal IPv6 Address Format in URL's Syntax}} and [HTTP header field definition specification|https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html], correct request URL should be enclosed like following one: {{http://[fe80::56ee:75ff:fe47:c83e]}}
> Following code snippet creates request for URL {{http://fe80::56ee:75ff:fe47:c83e}}
> {code}
> HashMap<String, Object> map = new HashMap<String, Object>();
> map.put("host", "fe80::56ee:75ff:fe47:c83e");
> map.put("port", "8080");
> map.put(TransportConstants.HTTP_UPGRADE_ENABLED_PROP_NAME, true);
> TransportConfiguration transportConfiguration = new TransportConfiguration(NettyConnectorFactory.class.getName(), map);
> ConnectionFactory cf = ActiveMQJMSClient.createConnectionFactoryWithoutHA(JMSFactoryType.CF, transportConfiguration);
> connection = cf.createConnection();
> {code}
> This works fine when client connects directly to the server. However it may cause problems when Artemis connects to proxy which expects IPv6 address correctly enclosed.
> Artemis client should detect IPv6 address and enclose it, so it conforms to specification.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)