You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dlab.apache.org by dg...@apache.org on 2020/09/16 09:44:46 UTC
[incubator-dlab] 03/03: [DLAB-2047]: Made fixed size for library
management popup
This is an automated email from the ASF dual-hosted git repository.
dgnatyshyn pushed a commit to branch DLAB-2047
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git
commit 404be0d3e6b6195cfb9087efbc0a5f3b36d4bd95
Author: Dmytro_Gnatyshyn <di...@ukr.net>
AuthorDate: Wed Sep 16 12:44:22 2020 +0300
[DLAB-2047]: Made fixed size for library management popup
---
.../install-libraries.component.html | 7 +--
.../install-libraries.component.scss | 55 +++++++++++++---------
2 files changed, 36 insertions(+), 26 deletions(-)
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
index fcf8bcd..0ac1432 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
@@ -361,13 +361,14 @@
</div>
</mat-list-item>
</ng-container>
- <div *ngIf="!filtredNotebookLibs.length && notebookLibs?.length" class="scrollingList info message">
- <p>No matches found</p>
- </div>
+
</div>
<div *ngIf="!notebookLibs?.length" class="scrollingList info message">
<p>You have no libraries installed</p>
</div>
+ <div *ngIf="!filtredNotebookLibs.length && notebookLibs?.length" class="scrollingList info message">
+ <p>No matches found</p>
+ </div>
</mat-list>
</div>
<div class="m-top-15 actions" *ngIf="!uploading && notebook?.status === 'running'">
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss
index c93e5fb..3c60199 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss
@@ -30,7 +30,7 @@
flex: initial;
justify-content: center;
flex-direction: initial;
- margin-bottom: 25px;
+ margin-bottom: 10px;
bottom: 30px;
left: 0;
right: 0;
@@ -72,7 +72,7 @@
.install-libraries {
height: 100%;
- padding-bottom: 130px;
+ padding-bottom: 110px;
.dialog-header {
padding-left: 25px;
@@ -349,7 +349,7 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
}
.libs-info {
- padding: 0 20px;
+ padding: 0 25px;
display: flex;
flex: 1 1 auto;
min-height: 0;
@@ -369,13 +369,14 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
}
}
-
.mat-list {
width: 100%;
overflow-y: auto;
overflow-x: overlay;
position: relative;
- max-height: 350px;
+ height: 350px;
+ padding-top: 0;
+ margin-top: 8px;
.list-header{
line-height: 40px;
@@ -394,10 +395,6 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
.scrollingList {
- //max-height: 300px;
- //height: 80%;
-
-
.info {
p {
text-align: center;
@@ -619,28 +616,40 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
}
}
- @media screen and (min-width: 1281px) {
+@media screen and (max-height: 840px) {
.libs-info {
- height: 60%;
-
.mat-list {
- .scrollingList {
- max-height: 300px;
- height: 80%;
- }
+ height: 250px;
+
}
}
}
-@media screen and (max-height: 800px) {
- .libs-info {
- height: 50%;
+ @media screen and (max-height: 720px) {
+ .libs-info {
+ .mat-list {
+ height: 200px;
+ }
+ }
+ }
+@media screen and (max-height: 640px) {
+
+ .aligner>div.actions {
+ margin-bottom: 0;
+ }
+
+ .install-libraries {
+ padding-bottom: 90px;
+ }
+
+ .libs-info {
.mat-list {
- .scrollingList {
- max-height: 140px;
- height: 60%;
- }
+ height: 160px;
}
}
+
+ .message {
+ padding: 10px 20px;
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@dlab.apache.org
For additional commands, e-mail: commits-help@dlab.apache.org