You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/08 13:07:00 UTC
[GitHub] [flink] nizhikov opened a new pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
nizhikov opened a new pull request #17438:
URL: https://github.com/apache/flink/pull/17438
## What is the purpose of the change
Fix NPE in `CatalogTableImpl#getDescription` in case comment is null.
## Brief change log
- `Optional.of` replaced with `Optional.ofNullable`.
- test `CatalogTableImpTest#testNullComment` added.
## Verifying this change
This change added tests and can be verified as follows:
- Call `CatalogTableImpl#getDescription` after creation of table with null comment.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): don't know
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-939267119
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859",
"triggerID" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nizhikov commented on a change in pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #17438:
URL: https://github.com/apache/flink/pull/17438#discussion_r725462366
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/AbstractCatalogTable.java
##########
@@ -37,18 +39,18 @@
// Properties of the table
private final Map<String, String> options;
// Comment of the table
- private final String comment;
+ @Nullable private final String comment;
public AbstractCatalogTable(
- TableSchema tableSchema, Map<String, String> options, String comment) {
+ TableSchema tableSchema, Map<String, String> options, @Nullable String comment) {
this(tableSchema, new ArrayList<>(), options, comment);
}
public AbstractCatalogTable(
TableSchema tableSchema,
List<String> partitionKeys,
Map<String, String> options,
- String comment) {
+ @Nullable String comment) {
Review comment:
Thanks for the feedback.
Patch reworked according to your proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938630862
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 (Fri Oct 08 13:10:13 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-939218504
The build is failed because of wrong code format. You can [setup the code formatting plugin](https://nightlies.apache.org/flink/flink-docs-master/docs/flinkdev/ide_setup/#code-formatting), so that they can be fixed when developing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859",
"triggerID" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"triggerType" : "PUSH"
}, {
"hash" : "0c66bb628bffb8b866f4840c2170778382b86908",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24905",
"triggerID" : "939267119",
"triggerType" : "MANUAL"
}, {
"hash" : "0c66bb628bffb8b866f4840c2170778382b86908",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24905",
"triggerID" : "0c66bb628bffb8b866f4840c2170778382b86908",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "939267119",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0c66bb628bffb8b866f4840c2170778382b86908 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859",
"triggerID" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939267119",
"triggerType" : "MANUAL"
}, {
"hash" : "0c66bb628bffb8b866f4840c2170778382b86908",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24905",
"triggerID" : "939267119",
"triggerType" : "MANUAL"
}, {
"hash" : "0c66bb628bffb8b866f4840c2170778382b86908",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24905",
"triggerID" : "0c66bb628bffb8b866f4840c2170778382b86908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0c66bb628bffb8b866f4840c2170778382b86908 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #17438:
URL: https://github.com/apache/flink/pull/17438#discussion_r725427333
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/AbstractCatalogTable.java
##########
@@ -37,18 +39,18 @@
// Properties of the table
private final Map<String, String> options;
// Comment of the table
- private final String comment;
+ @Nullable private final String comment;
public AbstractCatalogTable(
- TableSchema tableSchema, Map<String, String> options, String comment) {
+ TableSchema tableSchema, Map<String, String> options, @Nullable String comment) {
this(tableSchema, new ArrayList<>(), options, comment);
}
public AbstractCatalogTable(
TableSchema tableSchema,
List<String> partitionKeys,
Map<String, String> options,
- String comment) {
+ @Nullable String comment) {
Review comment:
According to the Javadoc of `getComment()`, it doesn't say the return value can be null. There is no `@Nullable` annotation on the return type as well. The default implementation of `CatalogTable#getComment` and `CatalogView#getComment` (`DefaultCatalogTable`, `DefaultCatalogView`) returns empty string instead of null.
Therefore, would be better to return `comment != null ? comment : ""` in `AbstractCatalogTable#getComment` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859",
"triggerID" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82cfa4deb7c10c8214e2138aa95332bad4ade3d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17438:
URL: https://github.com/apache/flink/pull/17438#issuecomment-938665309
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24859",
"triggerID" : "82cfa4deb7c10c8214e2138aa95332bad4ade3d9",
"triggerType" : "PUSH"
}, {
"hash" : "0c66bb628bffb8b866f4840c2170778382b86908",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "939267119",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "939267119",
"triggerType" : "MANUAL"
}, {
"hash" : "0c66bb628bffb8b866f4840c2170778382b86908",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c66bb628bffb8b866f4840c2170778382b86908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0c66bb628bffb8b866f4840c2170778382b86908 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #17438: [FLINK-24389] [Table SQL / API] Fix NPE in CatalogTableImpl#getDescription
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #17438:
URL: https://github.com/apache/flink/pull/17438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org