You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2024/05/25 08:25:45 UTC
[PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]
m1a2st opened a new pull request, #16081:
URL: https://github.com/apache/kafka/pull/16081
This issue https://issues.apache.org/jira/browse/KAFKA-16805, I change the `reports` method to `reports.configure` to avoid use the ClosureBackedAction interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16081:
URL: https://github.com/apache/kafka/pull/16081#issuecomment-2134661663
```
chia7712@chia7712-ubuntu:~/project/kafka$ ./gradlew clean build -x test --warning-mode all
Starting a Gradle Daemon, 8 stopped Daemons could not be reused, use --status for details
> Configure project :
Starting build with version 3.8.0-SNAPSHOT (commit id 91284d8d) using Gradle 8.7, Java 17 and Scala 2.13.14
Build properties: maxParallelForks=24, maxScalacThreads=8, maxTestRetries=0
Build file '/home/chia7712/project/kafka/build.gradle': line 310
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#java_convention_deprecation
at build_dfxsezet52f5eom30zrzfpxff$_run_closure4.doCall$original(/home/chia7712/project/kafka/build.gradle:310)
(Run with --stacktrace to get the full stack trace of this deprecation warning.)
at build_dfxsezet52f5eom30zrzfpxff.run(/home/chia7712/project/kafka/build.gradle:246)
(Run with --stacktrace to get the full stack trace of this deprecation warning.)
Build file '/home/chia7712/project/kafka/build.gradle': line 311
The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#java_convention_deprecation
at build_dfxsezet52f5eom30zrzfpxff$_run_closure4.doCall$original(/home/chia7712/project/kafka/build.gradle:311)
(Run with --stacktrace to get the full stack trace of this deprecation warning.)
at build_dfxsezet52f5eom30zrzfpxff.run(/home/chia7712/project/kafka/build.gradle:246)
(Run with --stacktrace to get the full stack trace of this deprecation warning.)
The org.gradle.util.ConfigureUtil type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#org_gradle_util_reports_deprecations
at build_dfxsezet52f5eom30zrzfpxff$_run_closure18.doCall$original(/home/chia7712/project/kafka/build.gradle:1511)
(Run with --stacktrace to get the full stack trace of this deprecation warning.)
```
the warnings about `ClosureBackedAction` is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16081:
URL: https://github.com/apache/kafka/pull/16081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16081:
URL: https://github.com/apache/kafka/pull/16081#discussion_r1615743021
##########
build.gradle:
##########
@@ -743,7 +743,7 @@ subprojects {
test.dependsOn('spotbugsMain')
tasks.withType(com.github.spotbugs.snom.SpotBugsTask) {
- reports {
+ reports.configure { reports ->
Review Comment:
We don't use variable `reports`, so `reports ->` can be omitted.
##########
build.gradle:
##########
@@ -743,7 +743,7 @@ subprojects {
test.dependsOn('spotbugsMain')
tasks.withType(com.github.spotbugs.snom.SpotBugsTask) {
Review Comment:
Could we address https://docs.gradle.org/current/userguide/task_configuration_avoidance.html in this PR?
`tasks.withType(com.github.spotbugs.snom.SpotBugsTask).configureEach`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16081:
URL: https://github.com/apache/kafka/pull/16081#issuecomment-2133786536
@m1a2st Our QA can't verify this PR I feel, so could you please test related configs and then attach the screenshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16081:
URL: https://github.com/apache/kafka/pull/16081#issuecomment-2134163903
Generating report is still working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org