You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:51:29 UTC

[GitHub] [flink] xuyangzhong opened a new pull request, #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

xuyangzhong opened a new pull request, #19866:
URL: https://github.com/apache/flink/pull/19866

   ## What is the purpose of the change
   
    If leftSize or rightSize is unknown or equal in Semi/Anti Join, the right side of the join should be chosen as build side.
   
   ## Brief change log
   
     - Choose right side instead of left side in `BatchPhysicalHashJoinRule`
   
   ## Verifying this change
   
   Existent test cases can cover this change.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1857405822

   Hi, @lsyldliu. I rebased the master. Could you have a look again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1859051852

   @xuyangzhong Do you think we should pick this fix to release-1.18?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on pull request #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1160571999

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on pull request #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1153402983

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu merged PR #19866:
URL: https://github.com/apache/flink/pull/19866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1860163668

   > @xuyangzhong Do you think we should pick this fix to release-1.18?
   
   I feel that cp is not needed because it changes the plan and will cause compatibility issues. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on pull request #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1152063040

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on pull request #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1152142595

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on pull request #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1163227335

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on code in PR #19866:
URL: https://github.com/apache/flink/pull/19866#discussion_r1427570136


##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/MultipleInputCreationTest.xml:
##########
@@ -109,39 +109,6 @@ MultipleInput(readOrder=[0,1,0], members=[\nNestedLoopJoin(joinType=[LeftOuterJo
 :  +- LegacyTableSourceScan(table=[[default_catalog, default_database, x, source: [TestTableSource(a, b, c, nx)]]], fields=[a, b, c, nx])
 +- Exchange(distribution=[broadcast])
    +- LegacyTableSourceScan(table=[[default_catalog, default_database, y, source: [TestTableSource(d, e, f, ny)]]], fields=[d, e, f, ny])
-]]>
-    </Resource>
-  </TestCase>
-  <TestCase name="testIncludeCalcForChainableSource[shuffleMode: ALL_EXCHANGES_BLOCKING, schedulerType: AdaptiveBatch]">

Review Comment:
   Actually this test is not deleted. I just delete this xml, let Flink to generate it again, and the order about tests in this file has been changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19866: [FLINK-27876][table-planner] choose right side as build side if left size is equal with right in semi/anti

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19866:
URL: https://github.com/apache/flink/pull/19866#issuecomment-1144364960

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "217c2b1f0381ade8b427aecb01a490a921c945a3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "217c2b1f0381ade8b427aecb01a490a921c945a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 217c2b1f0381ade8b427aecb01a490a921c945a3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-27876][table-planner] Choose the right side as build side when using default shuffle hash strategy if left size is equal with right [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu commented on code in PR #19866:
URL: https://github.com/apache/flink/pull/19866#discussion_r1410558281


##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/MultipleInputCreationTest.xml:
##########
@@ -109,39 +109,6 @@ MultipleInput(readOrder=[0,1,0], members=[\nNestedLoopJoin(joinType=[LeftOuterJo
 :  +- LegacyTableSourceScan(table=[[default_catalog, default_database, x, source: [TestTableSource(a, b, c, nx)]]], fields=[a, b, c, nx])
 +- Exchange(distribution=[broadcast])
    +- LegacyTableSourceScan(table=[[default_catalog, default_database, y, source: [TestTableSource(d, e, f, ny)]]], fields=[d, e, f, ny])
-]]>
-    </Resource>
-  </TestCase>
-  <TestCase name="testIncludeCalcForChainableSource[shuffleMode: ALL_EXCHANGES_BLOCKING, schedulerType: AdaptiveBatch]">

Review Comment:
   I have one question: this doesn't have a change, why this plan has been deleted? I think your changes doesn't affect this test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org