You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Spiridon Eliopoulos (JIRA)" <ji...@apache.org> on 2009/03/19 20:58:50 UTC
[jira] Created: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
64-bit integer and double types incorrectly serialized on 32-bit platforms
--------------------------------------------------------------------------
Key: THRIFT-385
URL: https://issues.apache.org/jira/browse/THRIFT-385
Project: Thrift
Issue Type: Bug
Components: Compiler (Haskell)
Environment: Mac OS X Leopard
Reporter: Spiridon Eliopoulos
Assignee: Spiridon Eliopoulos
Priority: Minor
The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Spiridon Eliopoulos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Spiridon Eliopoulos updated THRIFT-385:
---------------------------------------
Patch Info: [Patch Available]
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-385.
----------------------------------
Resolution: Fixed
Committed. Thanks for the patch!
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-385.
------------------------------
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683923#action_12683923 ]
Bryan Duxbury commented on THRIFT-385:
--------------------------------------
In principle, at least, I think this patch looks great. I have no practical knowledge of Haskell, though. Any Haskell people want to step up and +1 this issue? If not, I'll just commit it.
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Spiridon Eliopoulos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Spiridon Eliopoulos resolved THRIFT-385.
----------------------------------------
Resolution: Fixed
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reopened THRIFT-385:
----------------------------------
Unless I'm mistaken, this patch hasn't been committed, so it should remain open. if your intent was to mark the issue as "committable", then click Edit and check the "Patch Available" checkbox, and start harassing a committer to review and commit it for you.
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-385) 64-bit integer and double types
incorrectly serialized on 32-bit platforms
Posted by "Spiridon Eliopoulos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Spiridon Eliopoulos updated THRIFT-385:
---------------------------------------
Attachment: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
patch to fix this bug
> 64-bit integer and double types incorrectly serialized on 32-bit platforms
> --------------------------------------------------------------------------
>
> Key: THRIFT-385
> URL: https://issues.apache.org/jira/browse/THRIFT-385
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Haskell)
> Environment: Mac OS X Leopard
> Reporter: Spiridon Eliopoulos
> Assignee: Spiridon Eliopoulos
> Priority: Minor
> Attachments: 0001-THRIFT-385.-haskell-Fixed-bug-in-Int64-and-Double.patch
>
>
> The type currently being used for the 64-bit integer type is Int. On 32-bit platforms, this type only contains 32 bits and so 64-bit integers are being truncated before they're sent over the wire. In addition, serialization for the double type is being offloaded to the 64-bit integer type, and is therefore being truncated as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.