You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jrushf1239k <gi...@git.apache.org> on 2016/02/22 18:45:04 UTC
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
GitHub user jrushf1239k opened a pull request:
https://github.com/apache/trafficserver/pull/494
TS4095: fix the plugins/experimental/Makefile.am for webp_transform plugin.
Could not build the master branch this morning as there were build errors with the webp_transform plugin.
$ autoreconf -vif
$ ./configure --prefix=/opt/trafficserver --with-user=ats --with-group=ats --enable-experimental-plugins
$ make
make[3]: Entering directory `/home/jrushf1239k/trafficserver/plugins/experimental/webp_transform'
make[3]: *** No rule to make target `all'. Stop.
make[3]: Leaving directory `/home/jrushf1239k/trafficserver/plugins/experimental/webp_transform'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/jrushf1239k/trafficserver/plugins/experimental'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jrushf1239k/trafficserver/plugins'
make: *** [all-recursive] Error 1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jrushf1239k/trafficserver ts4095
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #494
----
commit 89fea2a9c987b94899aa6465f88a36204a5fd59a
Author: John J. Rushford <jo...@cable.comcast.com>
Date: 2016-02-22T17:36:17Z
fix the plugins/experimental/Makefile.am for webp_transform plugin.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
Posted by jrushf1239k <gi...@git.apache.org>.
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187374466
I think this change is good as the configure.ac has the enable-cppapi check. so, configure won't create a makefile unless both options are used. I tested the change in my environment and it fixes the problem. with only --enable-experminental-plugins, all builds okay. When I add --enable-cppapi and as long as I have the imagemagick libraries and the check passes, the webp_transform plugin is built.:
1941 AS_IF([test "x$enable_experimental_plugins" = "xyes"], [
1942 AS_IF([test "x$enable_cppapi" = "xyes"], [
1943 AC_CONFIG_FILES([plugins/experimental/webp_transform/Makefile])
1944 ])])
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187297552
Yup, just as James said. enable-cppapi check is needed as well.
Also thanks for the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
Posted by myraid <gi...@git.apache.org>.
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187401027
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187394404
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS4095: fix the plugins/experimental/M...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187291464
I think you need to go further here. The C++ API is an optional component, so we also need to check that it is being built.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---