You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/06/12 17:34:06 UTC

[GitHub] [phoenix] kadirozde commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable Global Indexes for Non-Transactiona…

kadirozde commented on a change in pull request #517: PHOENIX-5211 Consistent Immutable Global Indexes for Non-Transactiona…
URL: https://github.com/apache/phoenix/pull/517#discussion_r293034007
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
 ##########
 @@ -17,10 +17,15 @@
  */
 package org.apache.phoenix.end2end.index;
 
+import static org.apache.phoenix.end2end.IndexToolIT.assertExplainPlan;
+import static org.apache.phoenix.schema.types.PDataType.FALSE_BYTES;
+import static org.apache.phoenix.schema.types.PDataType.TRUE_BYTES;
 
 Review comment:
   Instead of using TRUE_BYTES and FALSE_BYTES, please use IndexRegionObserver.UNVERIFIED_BYTES and IndexRegionObserver.VERIFIED_BYTES. I have changed this recently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services