You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2011/03/19 02:49:29 UTC
[jira] Created: (SOLR-2435) Duplicate Jars in release packages
Duplicate Jars in release packages
----------------------------------
Key: SOLR-2435
URL: https://issues.apache.org/jira/browse/SOLR-2435
Project: Solr
Issue Type: Bug
Reporter: Hoss Man
Fix For: 3.1
Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2435) Duplicate Jars in release packages
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008710#comment-13008710 ]
Hoss Man commented on SOLR-2435:
--------------------------------
I've marked this for 3.1 in the hopes that it gets some attention from people motivated to fix it ... but i don't really think we should worry about it being a blocker unless we find cases where we are shipping conflicting versions of a single jar. (i haven't dug in enough to check)
(as rmuir said on irc: if the jars are identical, they should compress nicely)
in the ICU4J case, at a minimum we can promote the jar up out of the individual contirbs and into the main "lib" dir ... but since it's also in modules, it should be possible to have it copied into the lucene-libs dir (although i'm not totally up to speed on what builds that dir right now)
> Duplicate Jars in release packages
> ----------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Fix For: 3.1
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2435) Duplicate Jars in release packages
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244538#comment-13244538 ]
Robert Muir commented on SOLR-2435:
-----------------------------------
{quote}
in the ICU4J case, at a minimum we can promote the jar up out of the individual contirbs and into the main "lib" dir ... but since it's also in modules, it should be possible to have it copied into the lucene-libs dir (although i'm not totally up to speed on what builds that dir right now)
{quote}
Seeing as now this issue only affects the _binary release_ and no longer the source one :)
I think its much less of an issue. I'm not sure how it helps to have icu4j in lucene-libs versus coming into lib/.
I definitely don't think its a blocker (as we said before, especially now that it doesnt affect source release),
but its nice to clean up: the junit one is especially confusing, so I'm committing that one to trunk.
> Duplicate Jars in release packages
> ----------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Fix For: 4.0
>
> Attachments: SOLR-2435_duplicate_junit.patch, SOLR-2435_duplicate_junit.patch
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2435) Duplicate Jars in release packages
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008717#comment-13008717 ]
Hoss Man commented on SOLR-2435:
--------------------------------
FWIW: This is the current count of all jars in the solr _source_ packages on the 3_1 branch...
{noformat}
$ find -name \*.jar | perl -lpe 's/.*\///' | sort | uniq -c | sort -rn
3 icu4j-4_6.jar
2 log4j-1.2.14.jar
2 junit-4.7.jar
2 commons-beanutils-1.7.0.jar
1 xmlbeans-2.3.0.jar
1 xml-apis-1.0.b2.jar
1 xercesImpl-2.9.1-patched-XERCESJ-1257.jar
1 xercesImpl-2.8.1.jar
1 wstx-asl-3.2.7.jar
1 velocity-tools-2.0-beta3.jar
1 velocity-1.6.1.jar
1 uimaj-core-2.3.1.jar
1 uima-an-wst-2.3.1-SNAPSHOT-r1076132.jar
1 uima-an-tagger-2.3.1-SNAPSHOT-r1062868.jar
1 uima-an-calais-2.3.1-SNAPSHOT-r1062868.jar
1 uima-an-alchemy-2.3.1-SNAPSHOT-r1062868.jar
1 tika-parsers-0.8.jar
1 tika-core-0.8.jar
1 tagsoup-1.2.jar
1 start.jar
1 slf4j-jdk14-1.5.5.jar
1 slf4j-api-1.5.5.jar
1 simple-xml-1.7.3.jar
1 servlet-api-2.5-20081211.jar
1 servlet-api-2.4.jar
1 rome-0.9.jar
1 poi-scratchpad-3.7.jar
1 poi-ooxml-schemas-3.7.jar
1 poi-ooxml-3.7.jar
1 poi-3.7.jar
1 pdfbox-1.3.1.jar
1 pcj-1.2.jar
1 nni-1.0.0.jar
1 netcdf-4.2.jar
1 metadata-extractor-2.4.0-beta-1.jar
1 mail-1.4.1.jar
1 mahout-math-0.3.jar
1 mahout-collections-0.3.jar
1 lucene-core-3.0.2.jar
1 jtidy-r938.jar
1 jsp-api-2.1-glassfish-2.1.v20091210.jar
1 jsp-2.1-jetty-6.1.26.jar
1 jsp-2.1-glassfish-2.1.v20091210.jar
1 jline.jar
1 jetty-util-6.1.26-patched-JETTY-1340.jar
1 jetty-6.1.26-patched-JETTY-1340.jar
1 jempbox-1.3.1.jar
1 jcl-over-slf4j-1.5.5.jar
1 jakarta-regexp-1.4.jar
1 jackson-mapper-asl-1.5.2.jar
1 jackson-core-asl-1.5.2.jar
1 hsqldb-1.8.0.10.jar
1 hppc-0.3.1.jar
1 guava-r05.jar
1 geronimo-stax-api_1.0_spec-1.0.1.jar
1 fontbox-1.3.1.jar
1 easymock-2.2.jar
1 dom4j-1.6.1.jar
1 core-3.1.1.jar
1 commons-logging-1.1.1.jar
1 commons-logging-1.0.4.jar
1 commons-lang-2.4.jar
1 commons-io-1.4.jar
1 commons-httpclient-3.1.jar
1 commons-fileupload-1.2.1.jar
1 commons-digester-2.0.jar
1 commons-digester-1.7.jar
1 commons-csv-1.0-SNAPSHOT-r966014.jar
1 commons-compress-1.1.jar
1 commons-compress-1.0.jar
1 commons-collections-3.2.1.jar
1 commons-collections-3.1.jar
1 commons-codec-1.4.jar
1 colt-1.2.0.jar
1 carrot2-core-3.4.2.jar
1 boilerpipe-1.1.0.jar
1 bcprov-jdk15-1.45.jar
1 bcmail-jdk15-1.45.jar
1 asm-3.1.jar
1 apache-solr-noggit-r944541.jar
1 ant-junit-1.7.1.jar
1 ant-1.7.1.jar
1 activation-1.1.jar
{noformat}
These are the ones that seem a bit alarming at first glance...
{noformat}
1 xercesImpl-2.9.1-patched-XERCESJ-1257.jar
1 xercesImpl-2.8.1.jar
1 commons-logging-1.1.1.jar
1 commons-logging-1.0.4.jar
1 commons-digester-2.0.jar
1 commons-digester-1.7.jar
1 commons-compress-1.1.jar
1 commons-compress-1.0.jar
1 commons-collections-3.2.1.jar
1 commons-collections-3.1.jar
{noformat}
...but the overlaps all come from contrib/benchmark, so the odds of someone having two different versions of those in their classpath when running solr are low.
What is kind of concerning is that benchmark is using a patched version of xercesImpl because of XERCESJ-1257, but SolrCell is using xercesImpl-2.8.1.jar ... should SolrCell be using the patched version as well?
> Duplicate Jars in release packages
> ----------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Fix For: 3.1
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2435) Duplicate Jars in release packages
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-2435:
------------------------------
Attachment: SOLR-2435_duplicate_junit.patch
patch for the duplicate junit: its worthless and confusing, and trivial to fix (just nuke it).
> Duplicate Jars in release packages
> ----------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Fix For: 4.0
>
> Attachments: SOLR-2435_duplicate_junit.patch
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2435) Duplicate Jars in (binary) release
packages
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-2435:
---------------------------
Fix Version/s: (was: 4.0)
Summary: Duplicate Jars in (binary) release packages (was: Duplicate Jars in release packages)
Removing fix version and updating summary (as rmuir has noted, this isn't really a priority)
As always: if someone wants to take on this work they are welcome to do so at any time and the target release can be revisited
> Duplicate Jars in (binary) release packages
> -------------------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Attachments: SOLR-2435_duplicate_junit.patch, SOLR-2435_duplicate_junit.patch
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2435) Duplicate Jars in release packages
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-2435:
---------------------------
Fix Version/s: (was: 3.1)
3.2
no one seems to think this is a 3.1 blocker, moving to 3.2
> Duplicate Jars in release packages
> ----------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Fix For: 3.2
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2435) Duplicate Jars in release packages
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-2435:
------------------------------
Attachment: SOLR-2435_duplicate_junit.patch
updated patch: with test-framework ref'ing test.classpath in its javadoc.classpath so that test-framework javadocs work.
this is ready for trunk.
> Duplicate Jars in release packages
> ----------------------------------
>
> Key: SOLR-2435
> URL: https://issues.apache.org/jira/browse/SOLR-2435
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Fix For: 4.0
>
> Attachments: SOLR-2435_duplicate_junit.patch, SOLR-2435_duplicate_junit.patch
>
>
> Reviewing the 3.1 release candidates, i've noticed that in a few places we have duplicated jars.
> of particular note is the "ICU4J" jar, which not only exists in two different solr contrib lib directories, but also exists in modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org