You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "guohao-rosicky (via GitHub)" <gi...@apache.org> on 2023/11/02 03:56:26 UTC
[PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
guohao-rosicky opened a new pull request, #5534:
URL: https://github.com/apache/ozone/pull/5534
## What changes were proposed in this pull request?
When uploading a file with the same name using a slice overwrite, if the number of previous copies is not the same as the current one, the meta information is updated incorrectly.
Example:
1. a file with the name a is uploaded the first time it is ratis 3 factor
2. the second time a file with the same name a is uploaded using multipart upload it is ec-3-2-1024k
3. the replication config in the meta-information is recorded as ratis 3 factor, but it should actually be ec-3-2-1024k.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #5534:
URL: https://github.com/apache/ozone/pull/5534#issuecomment-1790257680
@guohao-rosicky Thank you for the patch. I saw a lot of similar issues where a request wanted to update certain attributes from a entity, but forget some properties, causing these forgotten properties to be unset.
I think it would be better if the solution is similar @sumitagrawl 's HDDS-9110 (https://github.com/apache/ozone/pull/5138) where it uses `OmBucketInfo.toBuilder` from the existing `OmBucketInfo` and only. We can introduce similar method `OmKeyInfo.toBuilder` which take the existing `OmKeyInfo` and update the relevant properties from there. So in the future, if we add more properties, we can just update `OmKeyinfo.toBuilder` to include the new property.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "xBis7 (via GitHub)" <gi...@apache.org>.
xBis7 commented on PR #5534:
URL: https://github.com/apache/ozone/pull/5534#issuecomment-1790562405
@guohao-rosicky Thanks for the patch. Can you add a comment with a manual test case before and after the change? Also, can we verify it's consistent with FSO as well?
When saying test case, I mean show what the issue is before the change and that it's fixed after the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi merged PR #5534:
URL: https://github.com/apache/ozone/pull/5534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5534:
URL: https://github.com/apache/ozone/pull/5534#issuecomment-1790023701
@kerneltime PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #5534:
URL: https://github.com/apache/ozone/pull/5534#issuecomment-1790092750
@SaketaChalamchala @tanvipenumudy @xBis7 can you please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "guohao-rosicky (via GitHub)" <gi...@apache.org>.
guohao-rosicky commented on PR #5534:
URL: https://github.com/apache/ozone/pull/5534#issuecomment-1801186467
> @guohao-rosicky Thanks for the patch. Can you add a comment with a manual test case before and after the change? Also, can we verify it's consistent with FSO as well?
>
> When saying test case, I mean show what the issue is before the change and that it's fixed after the change.
sure. I've updated. Thanks @xBis7 PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9607. Overwrite file by multipart upload, saving wrong ReplicationConfig in KeyInfo [ozone]
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #5534:
URL: https://github.com/apache/ozone/pull/5534#issuecomment-1790074173
Thank you @guohao-rosicky I will take a look. Thank you for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org