You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/11 16:32:37 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request #152: Remove HTTP basic auth credentials from log, stacktrace, segment
Superskyyy opened a new pull request #152:
URL: https://github.com/apache/skywalking-python/pull/152
- Removes HTTP basic auth `user:pw` from span - `peer` `url` and `log` in http client libs
- Removes HTTP basic auth `user:pw` from log and tracebacks in log reporter
- Adds support for an extra configuration - `cause_exception_depth` which limits the stacktrace depth (align with Java agent)
- Updates some doc and config naming.
- Tested working for (requests, urllib3, urllib.request, aiohttp) under various settings, only two needs span fix.
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #152: Remove HTTP basic auth credentials from log, stacktrace, segment
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #152:
URL: https://github.com/apache/skywalking-python/pull/152#issuecomment-897305858
> Hi @Superskyyy , I saw you only update 2 http plugins to use the filters, did you check whether or not other http plugins need the same?
I checked the other two are fine, they seem to avoided that already. Also tested with some sample code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #152: Remove HTTP basic auth credentials from log, stacktrace, segment
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #152:
URL: https://github.com/apache/skywalking-python/pull/152#issuecomment-897264831
Hi @Superskyyy , I saw you only update 2 http plugins to use the filters, did you check whether or not other http plugins need the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #152: Remove HTTP basic auth credentials from log, stacktrace, segment
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #152:
URL: https://github.com/apache/skywalking-python/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org