You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/03 04:08:51 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1488: Add JDBC mode to store engine events.

pan3793 commented on a change in pull request #1488:
URL: https://github.com/apache/incubator-kyuubi/pull/1488#discussion_r761633916



##########
File path: externals/kyuubi-spark-sql-engine/pom.xml
##########
@@ -167,6 +167,7 @@
                     <shadedArtifactAttached>false</shadedArtifactAttached>
                     <artifactSet>
                         <includes>
+                            <include>com.alibaba:druid</include>

Review comment:
       HiKariCP should the better choice, evaluated from popularity, performance, and has native support of dropwizard and prometheus.  
   https://github.com/apache/dolphinscheduler/issues/6881




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org