You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by 吴晟 Sheng Wu <wu...@foxmail.com> on 2018/09/08 13:18:54 UTC
[VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Hi All,
This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-RC2.
The Apache SkyWalking community has tested, voted and approved the proposed
release of Apache SkyWalking (Incubating) 5.0.0-RC2
We now kindly request the Incubator PMC members review and vote on this
incubator release.
SkyWalking: APM (application performance monitor) tool for distributed systems,
especially designed for microservices, cloud native and container-based (Docker, Kubernetes, Mesos) architectures.
Underlying technology is a distributed tracing system.
Last RC release broke in IPMC vote, because our source release LICENSE and NOTICE have issues[1],
which are fixed in this release.
Vote Thread:
https://lists.apache.org/thread.html/442a5fc5a6b987c081e3932c967489fc746bf5ce887dfa5d5130d602@%3Cdev.skywalking.apache.org%3E
Release notes:
* https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md#500-rc
Release Candidate:
https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC2/
* sha512 checksums
- 867f66cbbda4d54c2ce8be2ae1b24f7f9fca745a8ccbb8a5a3689be86fbb47411125c65f9dc6b870f61847abc805376cdcb53952b406bf7f204af80fdf5ceacc apache-skywalking-apm-incubating-5.0.0-RC2-src.tgz
- a02a44da7090af2f958f5d7816ec7b8d1b379c91e6fc52d35259ca3ad4396c7663e0c64b3652426ca2ad4953e5c1a2f5db1c138ca6f9c411b5f3cd014a785831 apache-skywalking-apm-incubating-5.0.0-RC2.tar.gz
- 9a66409411e89f6eec2bc173187971fdea803d5d81450b5f74311902938564c66215c239e400cb2db91324d9e9903f59e8acb46c5a1c1e5f3e189ffa25e74124 apache-skywalking-apm-incubating-5.0.0-RC2.zip
Maven 2 staging repository:
* https://repository.apache.org/content/repositories/orgapacheskywalking-1020/org/apache/skywalking/
Release Tag :
* (GitHub Tag) https://github.com/apache/incubator-skywalking/tree/v5.0.0-RC2
Release CommitID :
* https://github.com/apache/incubator-skywalking/tree/30fad9f822e96dfa4d8018b3f7b32e4f11521263
* Git submodule
* skywalking-ui: https://github.com/apache/incubator-skywalking-ui/tree/ad3ee45dbadfae35d77238bdd7a1df593158f109
* apm-protocol/apm-network/src/main/proto: https://github.com/apache/incubator-skywalking-data-collect-protocol/tree/c02c12af12116121e25155d1f3fca0fadee5f2e9
Keys to verify the Release Candidate :
* https://dist.apache.org/repos/dist/release/incubator/skywalking/KEYS corresponding to wusheng@apache.org
Guide to build the release from source :
* https://github.com/apache/incubator-skywalking/blob/v5.0.0-RC2/docs/en/How-to-build.md
* `docs/en/How-to-build.md` in source release.
Voting will start now (2018/9/8 date) and will remain open for at least 72 hours, Request IPMC to give their vote.
[ ] +1 Release this package.
[ ] +0 No opinion.
[ ] -1 Do not release this package because....
[1] https://lists.apache.org/thread.html/9a16dac30bf74d6aa96ee23e1b35edd040f468ef536ad155e50c97b8@%3Cgeneral.incubator.apache.org%3E
------------------
Sheng Wu
Apache SkyWalking
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
> - how come the binary comes in zip format but the source does not.
Just someone write the release script doesn't write that part. No special reason. Maybe add it, too?
Sheng Wu
Apache SkyWalking
From Wu Sheng 's phone.
------------------ Original ------------------
From: Mick Semb Wever <mc...@apache.org>
Date: Wed,Sep 12,2018 6:33 PM
To: general <ge...@incubator.apache.org>
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
> Voting will start now (2018/9/8 date) and will remain open for at least
> 72 hours, Request IPMC to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
+1
Checked
- sha512s ok
- checked maven artefacts
- source artefact builds
- source artefact contents
- DISCLAIMER, LICENSE and NOTICE files
Question:
- how come the binary comes in zip format but the source does not.
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Mick Semb Wever <mc...@apache.org>.
> Voting will start now (2018/9/8 date) and will remain open for at least
> 72 hours, Request IPMC to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
+1
Checked
- sha512s ok
- checked maven artefacts
- source artefact builds
- source artefact contents
- DISCLAIMER, LICENSE and NOTICE files
Question:
- how come the binary comes in zip format but the source does not.
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Willem Jiang <wi...@gmail.com>.
+1 (Binding)
1. Checked signed key and sha512 of source and binary package of
https://dist.apache.org/repos/dist/dev/incubator/skywalking
2. Source code build successfully
3. Checked the artifacts in the staging repository
4. LICENSE and NOTICE are OK in source code and distribution package
5. Apache RAT checked
6. DISCLAIMER existed
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Sat, Sep 8, 2018 at 9:19 PM 吴晟 Sheng Wu <wu...@foxmail.com> wrote:
>
> Hi All,
> This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-RC2.
>
>
> The Apache SkyWalking community has tested, voted and approved the proposed
> release of Apache SkyWalking (Incubating) 5.0.0-RC2
>
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
>
> SkyWalking: APM (application performance monitor) tool for distributed systems,
> especially designed for microservices, cloud native and container-based (Docker, Kubernetes, Mesos) architectures.
> Underlying technology is a distributed tracing system.
>
>
>
>
> Last RC release broke in IPMC vote, because our source release LICENSE and NOTICE have issues[1],
> which are fixed in this release.
>
>
> Vote Thread:
>
>
> https://lists.apache.org/thread.html/442a5fc5a6b987c081e3932c967489fc746bf5ce887dfa5d5130d602@%3Cdev.skywalking.apache.org%3E
>
>
>
>
> Release notes:
>
>
>
>
> * https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md#500-rc
>
>
>
>
> Release Candidate:
>
>
>
>
> https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC2/
> * sha512 checksums
> - 867f66cbbda4d54c2ce8be2ae1b24f7f9fca745a8ccbb8a5a3689be86fbb47411125c65f9dc6b870f61847abc805376cdcb53952b406bf7f204af80fdf5ceacc apache-skywalking-apm-incubating-5.0.0-RC2-src.tgz
> - a02a44da7090af2f958f5d7816ec7b8d1b379c91e6fc52d35259ca3ad4396c7663e0c64b3652426ca2ad4953e5c1a2f5db1c138ca6f9c411b5f3cd014a785831 apache-skywalking-apm-incubating-5.0.0-RC2.tar.gz
> - 9a66409411e89f6eec2bc173187971fdea803d5d81450b5f74311902938564c66215c239e400cb2db91324d9e9903f59e8acb46c5a1c1e5f3e189ffa25e74124 apache-skywalking-apm-incubating-5.0.0-RC2.zip
>
>
>
>
> Maven 2 staging repository:
>
>
>
>
> * https://repository.apache.org/content/repositories/orgapacheskywalking-1020/org/apache/skywalking/
>
>
>
>
> Release Tag :
>
>
>
>
> * (GitHub Tag) https://github.com/apache/incubator-skywalking/tree/v5.0.0-RC2
>
>
>
>
> Release CommitID :
>
>
>
>
> * https://github.com/apache/incubator-skywalking/tree/30fad9f822e96dfa4d8018b3f7b32e4f11521263
> * Git submodule
> * skywalking-ui: https://github.com/apache/incubator-skywalking-ui/tree/ad3ee45dbadfae35d77238bdd7a1df593158f109
> * apm-protocol/apm-network/src/main/proto: https://github.com/apache/incubator-skywalking-data-collect-protocol/tree/c02c12af12116121e25155d1f3fca0fadee5f2e9
>
>
>
>
> Keys to verify the Release Candidate :
>
>
>
>
> * https://dist.apache.org/repos/dist/release/incubator/skywalking/KEYS corresponding to wusheng@apache.org
>
>
>
>
> Guide to build the release from source :
>
>
>
>
> * https://github.com/apache/incubator-skywalking/blob/v5.0.0-RC2/docs/en/How-to-build.md
> * `docs/en/How-to-build.md` in source release.
>
>
>
>
> Voting will start now (2018/9/8 date) and will remain open for at least 72 hours, Request IPMC to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
>
>
>
>
> [1] https://lists.apache.org/thread.html/9a16dac30bf74d6aa96ee23e1b35edd040f468ef536ad155e50c97b8@%3Cgeneral.incubator.apache.org%3E
>
>
>
> ------------------
> Sheng Wu
> Apache SkyWalking
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Ignasi Barrera <na...@apache.org>.
+1
* SHA 512 checksums are present and valid
* Signatures are valid
* The expanded source archive builds and passes tests
* Expanded source archives match the contents of the RC tags
* All LICENSE and NOTICE files are present and correct, including the
MIT stuff detected in the previous IPMC vote
* Incubator DISCLAIMER is present
* There are no binary files bundled in the source archives
* Signing keys are available in public PGP servers.
The README still contains a broken in the "Compiling" section, but I
don't consider it a blocker for the release. The document is in the
source release and also properly linked from the main "English
Document" page (linked from the README too) and it is trivial to
find.On Sun, 9 Sep 2018 at 19:19, Ignasi Barrera <na...@apache.org>
wrote:
>
> That's why I meant when I said finding the build instructions was
> trivial enough that I thought it should not block a release.
>
> The README contains a clear link to the Documentation (which is a link
> to a local file), and that file is a very comprehensive index with
> direct links to architecture, testing, building, etc. Even if the
> compiling link is broken it is so trivial to find the build
> instructions that I find the comment "unable to build from source" a
> bit strict.
>
> I mean, people used to build from source often have a file describing
> the typical "./configure && make && make install", and often have to
> spend some time reading through the different configure options to
> properly configure the software for their platform. It is OK and
> usually assumed that building from source will get some time, and I
> find this concrete case to be very trivial. It is just an inconvenient
> broken link, that has a proper replacement that is trivial to find.
>
>
> This said, (and I'm asking for some advice here as it's the first
> project I help mentoring) I think we should not block the release for
> this reason and I'd vote +1, but I don't know if the IPMC vote is more
> targetted to non-mentors, which could have a potentially different
> perspective of the project just by overseeing it from the distance.
>
>
> On Sun, 9 Sep 2018 at 10:47, Justin Mclean <ju...@classsoftware.com> wrote:
> >
> > Hi,
> >
> > > Justin, given that the next release will provide this information so clearly from the base directory, knowing that the next release will be in order, are you ok with letting this release pass through?
> >
> > That is not up to me, that is up for other IPMC members to vote +1 on it.
> >
> > Thanks,
> > Justin
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Ignasi Barrera <na...@apache.org>.
That's why I meant when I said finding the build instructions was
trivial enough that I thought it should not block a release.
The README contains a clear link to the Documentation (which is a link
to a local file), and that file is a very comprehensive index with
direct links to architecture, testing, building, etc. Even if the
compiling link is broken it is so trivial to find the build
instructions that I find the comment "unable to build from source" a
bit strict.
I mean, people used to build from source often have a file describing
the typical "./configure && make && make install", and often have to
spend some time reading through the different configure options to
properly configure the software for their platform. It is OK and
usually assumed that building from source will get some time, and I
find this concrete case to be very trivial. It is just an inconvenient
broken link, that has a proper replacement that is trivial to find.
This said, (and I'm asking for some advice here as it's the first
project I help mentoring) I think we should not block the release for
this reason and I'd vote +1, but I don't know if the IPMC vote is more
targetted to non-mentors, which could have a potentially different
perspective of the project just by overseeing it from the distance.
On Sun, 9 Sep 2018 at 10:47, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> > Justin, given that the next release will provide this information so clearly from the base directory, knowing that the next release will be in order, are you ok with letting this release pass through?
>
> That is not up to me, that is up for other IPMC members to vote +1 on it.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Justin, given that the next release will provide this information so clearly from the base directory, knowing that the next release will be in order, are you ok with letting this release pass through?
That is not up to me, that is up for other IPMC members to vote +1 on it.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Mick Semb Wever <mc...@apache.org>.
> First of all, there is a direct link to that build page, in README of
> master and 5.x branches. See
> https://github.com/apache/incubator-skywalking#compiling-project
> We have both links to document and compiling guide.
This is excellent in my opinion.
From the terminal I can read the README.md which clearly states:
> # Compiling project
> Follow this [document](docs/en/guides/How-to-build.md).
Then opening, again from the terminal, `docs/en/guides/How-to-build.md` gives me everything i need to know.
Justin, given that the next release will provide this information so clearly from the base directory, knowing that the next release will be in order, are you ok with letting this release pass through?
regards,
Mick
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
We already only post source tar link in website. They are potential developers, because they code plugins for many open source or commercial libs.
> Sounds to me like it's easier to compile official releases and that you should be trying to release more often perhaps?
Actually, yes. We discussed before in our community. We didn't want to release too often, like 1-2 weeks per releaae. Because that will burn the dev and ipmc people to do vote and check again and again. 😂
So we keep the release per 1 or 2 months. And let developer to build by themself.
Btw, they perfer GitHub because it is easier to pull request new plugin and bug fix.
Sheng Wu
Apache SkyWalking
From Wu Sheng 's phone.
------------------ Original ------------------
From: Justin Mclean <ju...@classsoftware.com>
Date: Sun,Sep 9,2018 0:18 PM
To: general <ge...@incubator.apache.org>
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Hi,
I’m not involved in your project, and I may be mistaken, but it seems to me you might have a wider issue here.
> Besides that, because many users are using git clone tag as sources too, although in Apache, we consider our source tar only. But in the community, they really use in another way, in our github issue, many compiling issue, even after we put this detailed guide.
So point them to the official releases and don’t promote the use of GitHub over other official channels, especially to users. I was surprised by that page when I saw instructions for GitHub first. Why would your users want to use unreleased source code? That should really only be for active contributors and committers on the project.
> Background story is, in our project repository, we are using git submodule, so we need the guide as detailed as possible. Such as git submodule init, git submodule update, etc.
Sounds to me like it's easier to compile official releases and that you should be trying to release more often perhaps?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I’m not involved in your project, and I may be mistaken, but it seems to me you might have a wider issue here.
> Besides that, because many users are using git clone tag as sources too, although in Apache, we consider our source tar only. But in the community, they really use in another way, in our github issue, many compiling issue, even after we put this detailed guide.
So point them to the official releases and don’t promote the use of GitHub over other official channels, especially to users. I was surprised by that page when I saw instructions for GitHub first. Why would your users want to use unreleased source code? That should really only be for active contributors and committers on the project.
> Background story is, in our project repository, we are using git submodule, so we need the guide as detailed as possible. Such as git submodule init, git submodule update, etc.
Sounds to me like it's easier to compile official releases and that you should be trying to release more often perhaps?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
Hi, Justin,
First of all, there is a direct link to that build page, in README of master and 5.x branches. See
https://github.com/apache/incubator-skywalking#compiling-project
We have both links to document and compiling guide.
Besides that, because many users are using git clone tag as sources too, although in Apache, we consider our source tar only. But in the community, they really use in another way, in our github issue, many compiling issue, even after we put this detailed guide.
Background story is, in our project repository, we are using git submodule, so we need the guide as detailed as possible. Such as git submodule init, git submodule update, etc.
That is why we build a long guide abouy how to build for convenience users.
Sheng Wu
Apache SkyWalking
From Wu Sheng 's phone.
------------------ Original ------------------
From: Justin Mclean <ju...@classsoftware.com>
Date: Sun,Sep 9,2018 9:26 AM
To: general <ge...@incubator.apache.org>
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Hi,
> Check our two major code branches,
> - master https://github.com/apache/incubator-skywalking
In which README no longer contains any build instruction or direct pointers to them. I don’t think this is an improvement.
So now I need to stop looking at the terminal, open up a browser, goto GitHub and look at the README.md there. I need to know to click on “Documents”, one page into that content, then read through two pages before finding a link on building, click on that and then read how to build from GitHub (not what I want) and then finally find after that it’s a single line "./mvnw clean package -DskipTests”. Why not just put that single line in the README?
> - 5.x https://github.com/apache/incubator-skywalking/tree/5.x
As above.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Check our two major code branches,
> - master https://github.com/apache/incubator-skywalking
In which README no longer contains any build instruction or direct pointers to them. I don’t think this is an improvement.
So now I need to stop looking at the terminal, open up a browser, goto GitHub and look at the README.md there. I need to know to click on “Documents”, one page into that content, then read through two pages before finding a link on building, click on that and then read how to build from GitHub (not what I want) and then finally find after that it’s a single line "./mvnw clean package -DskipTests”. Why not just put that single line in the README?
> - 5.x https://github.com/apache/incubator-skywalking/tree/5.x
As above.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Ignasi Barrera <na...@apache.org>.
Thanks for the detailed review, Justin. It is really appreciated. As I
commented in the PPMC vote:
"The README still contains a broken in the "Compiling" section, but I
wouldn't consider it a blocker for the release. The document is in the
source release and also properly linked from the main "English
Document" page (linked from the README too)."
Actually, the "Full docs" link appears in the README *before* the compiling
section, and in that link (which is not broken) there is a "Development"
section with the build instructions. That is so trivial to find (I found it
really quickly when verifying the broken link) that I don't think the
release should be blocked for this.
On Sun, Sep 9, 2018, 01:26 吴晟 Sheng Wu <wu...@foxmail.com> wrote:
> Hi, Justin
> First of all, yes, in this source release, the link is old. But because, I
> think only license and notice are blocks. I only update and fix these.
>
>
> For the guide, they are already fixed in codebase, just not in this
> release. Considering it is not block.
>
>
> Check our two major code branches,
> - master https://github.com/apache/incubator-skywalking
> - 5.x https://github.com/apache/incubator-skywalking/tree/5.x
>
>
> The compile guide pointer in readme file is already the related path.
>
>
> When next routine release, it will be included, at the end of Sep.
>
>
> Is that OK?
>
> Sheng Wu
> Apache SkyWalking
>
> From Wu Sheng 's phone.
>
>
> ------------------ Original ------------------
> From: Justin Mclean <ju...@classsoftware.com>
> Date: Sun,Sep 9,2018 6:50 AM
> To: general <ge...@incubator.apache.org>
> Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version
> 5.0.0-RC2
>
>
>
> Hi,
>
> Sorry but I still cannot vote +1 own this as the README.md still points to
> https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md
> for build instructions which gives a 404, please include the instructions
> on how the build the source in the release in the README.md or in a
> BUILD.md (or similarly named file) in the base directory.
>
> Try to think like a user of this software they download it and want to
> compile it, they read instructions, are asked to follow a link (annoying)
> and then the link gives a 404, at this point some of them are going to give
> up and you will never hear from them again. Sure some may be able to find
> How-to-build.md in the docs and get it working but their first experience
> of the project is not ideal. Releases need to include simple easy to follow
> instructions on how to build. Those instruction may changed form release to
> release so pointing people to URLs is not helpful. What for instance if you
> want to compile an older version and the URL only has instructions for the
> most recent version?
>
> I checked:
> - incubating in name
> - signatures and hashes good
> - DISCLAIMER exists
> - LICENSE and NOTICE good
> - no unexpected binary files
> - all source files have ASF headers
> - unable to build from source
>
> Thanks for fixing the license issue, however you also need to fix it in
> the binary release.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
Hi, Justin
First of all, yes, in this source release, the link is old. But because, I think only license and notice are blocks. I only update and fix these.
For the guide, they are already fixed in codebase, just not in this release. Considering it is not block.
Check our two major code branches,
- master https://github.com/apache/incubator-skywalking
- 5.x https://github.com/apache/incubator-skywalking/tree/5.x
The compile guide pointer in readme file is already the related path.
When next routine release, it will be included, at the end of Sep.
Is that OK?
Sheng Wu
Apache SkyWalking
From Wu Sheng 's phone.
------------------ Original ------------------
From: Justin Mclean <ju...@classsoftware.com>
Date: Sun,Sep 9,2018 6:50 AM
To: general <ge...@incubator.apache.org>
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Hi,
Sorry but I still cannot vote +1 own this as the README.md still points to https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md for build instructions which gives a 404, please include the instructions on how the build the source in the release in the README.md or in a BUILD.md (or similarly named file) in the base directory.
Try to think like a user of this software they download it and want to compile it, they read instructions, are asked to follow a link (annoying) and then the link gives a 404, at this point some of them are going to give up and you will never hear from them again. Sure some may be able to find How-to-build.md in the docs and get it working but their first experience of the project is not ideal. Releases need to include simple easy to follow instructions on how to build. Those instruction may changed form release to release so pointing people to URLs is not helpful. What for instance if you want to compile an older version and the URL only has instructions for the most recent version?
I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE good
- no unexpected binary files
- all source files have ASF headers
- unable to build from source
Thanks for fixing the license issue, however you also need to fix it in the binary release.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Sorry but I still cannot vote +1 own this as the README.md still points to https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md for build instructions which gives a 404, please include the instructions on how the build the source in the release in the README.md or in a BUILD.md (or similarly named file) in the base directory.
Try to think like a user of this software they download it and want to compile it, they read instructions, are asked to follow a link (annoying) and then the link gives a 404, at this point some of them are going to give up and you will never hear from them again. Sure some may be able to find How-to-build.md in the docs and get it working but their first experience of the project is not ideal. Releases need to include simple easy to follow instructions on how to build. Those instruction may changed form release to release so pointing people to URLs is not helpful. What for instance if you want to compile an older version and the URL only has instructions for the most recent version?
I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE good
- no unexpected binary files
- all source files have ASF headers
- unable to build from source
Thanks for fixing the license issue, however you also need to fix it in the binary release.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [RESULT][VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC2
Posted by Sheng Wu <wu...@apache.org>.
Hi all,
The vote for releasing Apache SkyWalking 5.0.0-RC2 (incubating) is closed, now.
Vote result:
3 (+1 binding) (Ignasi, Mick and William)
Thank you everyone for taking the time to review the release and help us.
I will process to publish the release and send ANNOUNCE.
Justin,
Our 5.x branch and master branch compiling document links have been fixed already, will be included in next release.
Sheng Wu
Apache SkyWalking
On 2018/09/08 13:18:54, "吴晟 Sheng Wu" <wu...@foxmail.com> wrote:
> Hi All,
> This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-RC2.
>
>
> The Apache SkyWalking community has tested, voted and approved the proposed
> release of Apache SkyWalking (Incubating) 5.0.0-RC2
>
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
>
> SkyWalking: APM (application performance monitor) tool for distributed systems,
> especially designed for microservices, cloud native and container-based (Docker, Kubernetes, Mesos) architectures.
> Underlying technology is a distributed tracing system.
>
>
>
>
> Last RC release broke in IPMC vote, because our source release LICENSE and NOTICE have issues[1],
> which are fixed in this release.
>
>
> Vote Thread:
>
>
> https://lists.apache.org/thread.html/442a5fc5a6b987c081e3932c967489fc746bf5ce887dfa5d5130d602@%3Cdev.skywalking.apache.org%3E
>
>
>
>
> Release notes:
>
>
>
>
> * https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md#500-rc
>
>
>
>
> Release Candidate:
>
>
>
>
> https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC2/
> * sha512 checksums
> - 867f66cbbda4d54c2ce8be2ae1b24f7f9fca745a8ccbb8a5a3689be86fbb47411125c65f9dc6b870f61847abc805376cdcb53952b406bf7f204af80fdf5ceacc apache-skywalking-apm-incubating-5.0.0-RC2-src.tgz
> - a02a44da7090af2f958f5d7816ec7b8d1b379c91e6fc52d35259ca3ad4396c7663e0c64b3652426ca2ad4953e5c1a2f5db1c138ca6f9c411b5f3cd014a785831 apache-skywalking-apm-incubating-5.0.0-RC2.tar.gz
> - 9a66409411e89f6eec2bc173187971fdea803d5d81450b5f74311902938564c66215c239e400cb2db91324d9e9903f59e8acb46c5a1c1e5f3e189ffa25e74124 apache-skywalking-apm-incubating-5.0.0-RC2.zip
>
>
>
>
> Maven 2 staging repository:
>
>
>
>
> * https://repository.apache.org/content/repositories/orgapacheskywalking-1020/org/apache/skywalking/
>
>
>
>
> Release Tag :
>
>
>
>
> * (GitHub Tag) https://github.com/apache/incubator-skywalking/tree/v5.0.0-RC2
>
>
>
>
> Release CommitID :
>
>
>
>
> * https://github.com/apache/incubator-skywalking/tree/30fad9f822e96dfa4d8018b3f7b32e4f11521263
> * Git submodule
> * skywalking-ui: https://github.com/apache/incubator-skywalking-ui/tree/ad3ee45dbadfae35d77238bdd7a1df593158f109
> * apm-protocol/apm-network/src/main/proto: https://github.com/apache/incubator-skywalking-data-collect-protocol/tree/c02c12af12116121e25155d1f3fca0fadee5f2e9
>
>
>
>
> Keys to verify the Release Candidate :
>
>
>
>
> * https://dist.apache.org/repos/dist/release/incubator/skywalking/KEYS corresponding to wusheng@apache.org
>
>
>
>
> Guide to build the release from source :
>
>
>
>
> * https://github.com/apache/incubator-skywalking/blob/v5.0.0-RC2/docs/en/How-to-build.md
> * `docs/en/How-to-build.md` in source release.
>
>
>
>
> Voting will start now (2018/9/8 date) and will remain open for at least 72 hours, Request IPMC to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
>
>
>
>
> [1] https://lists.apache.org/thread.html/9a16dac30bf74d6aa96ee23e1b35edd040f468ef536ad155e50c97b8@%3Cgeneral.incubator.apache.org%3E
>
>
>
> ------------------
> Sheng Wu
> Apache SkyWalking
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org