[GitHub] [spark] PerilousApricot commented on a change in pull request #28159: [WIP][SPARK-31363][SQL] Add DataSourceRegisterV2

[GitBox <gi...@apache.org>]

PerilousApricot commented on a change in pull request #28159: [WIP][SPARK-31363][SQL] Add DataSourceRegisterV2
URL: https://github.com/apache/spark/pull/28159#discussion_r410299445
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala
 ##########
 @@ -50,6 +50,40 @@ trait DataSourceRegister {
   def shortName(): String
 }
 
+/**
+ * Extended version of [[DataSourceRegister]] which allows a data source to
+ * select an implementing class at runtime.  This allows plugin developers to
+ * choose the correct implementation at runtime, depending on the version of
+ * Spark the user is using.
+ *
+ *  A new instance of this class will be instantiated each time a DDL call is made.
+ *
+ */
+trait DataSourceRegisterV2 {
 
 Review comment:
   This is meant strictly as an improvement to the DataSourceRegister API,
   which also isn't used by the catalog.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org