[jira] [Resolved] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

["Erick Erickson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson resolved LUCENE-7788.
------------------------------------
    Fix Version/s: 8.6
       Resolution: Fixed

These checks are now wired in to gradle, both precommit and check. I did _NOT_ port all of the checks to the Ant build, so there's no equivalent checks in 8x.

That said, I did make all the changes to logging calls in both 8.6 and master.

> fail precommit on unparameterised log messages and examine for wasted work/objects
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-7788
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7788
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 8.6
>
>         Attachments: LUCENE-7788.patch, LUCENE-7788.patch, gradle_only.patch, gradle_only.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use and once that is in place then this ticket's one-line change would be for 'ant precommit' to reject any future unparameterised log.trace message use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org