You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2017/01/16 08:37:38 UTC
Re: Review Request 54057: LENS-1378 : Fix dimensions to query from
DenormalizationResolver for expression fields
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54057/#review161186
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (lines 191 - 192)
<https://reviews.apache.org/r/54057/#comment232999>
Should we make these datastructures local so that we don't need to reset them?
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 355)
<https://reviews.apache.org/r/54057/#comment233000>
Should we call this getNonReachableReferenceFields ?
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 395)
<https://reviews.apache.org/r/54057/#comment232603>
Should we call this getORCreateAndGetDeNormCtx ?
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java (line 284)
<https://reviews.apache.org/r/54057/#comment232998>
Can we add method level comments whereever possible.
- Puneet Gupta
On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54057/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2016, 6:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1378
> https://issues.apache.org/jira/browse/LENS-1378
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add DenormalizationContext for each expression instead of being part of main CubeQueryContext
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java e7fc557
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java e83ae76
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 40ed387
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 60dacdb
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 11eb8f7
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 89b50f5
> lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 41ea83d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java f2bb485
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 6430ed1
> tools/conf/server/logback.xml 63ab23c
>
> Diff: https://reviews.apache.org/r/54057/diff/
>
>
> Testing
> -------
>
> All cube tests passed
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 54057: LENS-1378 : Fix dimensions to query from
DenormalizationResolver for expression fields
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 16, 2017, 8:37 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java, lines 201-202
> > <https://reviews.apache.org/r/54057/diff/2/?file=1570253#file1570253line201>
> >
> > Should we make these datastructures local so that we don't need to reset them?
Not doing this, we it would require a lot changes in existing code.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54057/#review161186
-----------------------------------------------------------
On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54057/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2016, 6:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1378
> https://issues.apache.org/jira/browse/LENS-1378
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add DenormalizationContext for each expression instead of being part of main CubeQueryContext
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java e7fc557
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java e83ae76
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 40ed387
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 60dacdb
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 11eb8f7
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 89b50f5
> lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 41ea83d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java f2bb485
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 6430ed1
> tools/conf/server/logback.xml 63ab23c
>
> Diff: https://reviews.apache.org/r/54057/diff/
>
>
> Testing
> -------
>
> All cube tests passed
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 54057: LENS-1378 : Fix dimensions to query from
DenormalizationResolver for expression fields
Posted by Puneet Gupta <pu...@gmail.com>.
> On Jan. 16, 2017, 8:37 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java, lines 201-202
> > <https://reviews.apache.org/r/54057/diff/2/?file=1570253#file1570253line201>
> >
> > Should we make these datastructures local so that we don't need to reset them?
>
> Amareshwari Sriramadasu wrote:
> Not doing this, we it would require a lot changes in existing code.
ok
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54057/#review161186
-----------------------------------------------------------
On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54057/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2016, 6:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1378
> https://issues.apache.org/jira/browse/LENS-1378
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix is to add DenormalizationContext for each expression instead of being part of main CubeQueryContext
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java e7fc557
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java e83ae76
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 40ed387
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 60dacdb
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 11eb8f7
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 89b50f5
> lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java PRE-CREATION
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 41ea83d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java f2bb485
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 6430ed1
> tools/conf/server/logback.xml 63ab23c
>
> Diff: https://reviews.apache.org/r/54057/diff/
>
>
> Testing
> -------
>
> All cube tests passed
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>