[GitHub] [hive] maheshk114 commented on a change in pull request #722: HIVE-21956 : Add the list of table selected by dump in the dump folder.

[GitBox <gi...@apache.org>]

maheshk114 commented on a change in pull request #722: HIVE-21956 : Add the list of table selected by dump in the dump folder.
URL: https://github.com/apache/hive/pull/722#discussion_r303291314
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -219,13 +224,33 @@ private boolean shouldBootstrapDumpTable(Table table) {
     return !ReplUtils.tableIncludedInReplScope(work.oldReplScope, table.getTableName());
   }
 
+  private boolean isTableSatifiesConfig(Table table) {
+    if (table == null) {
+      return false;
+    }
+
+    if (TableType.EXTERNAL_TABLE.equals(table.getTableType())
+            && !conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_EXTERNAL_TABLES)) {
+      return false;
+    }
+
+    if (AcidUtils.isTransactionalTable(table)
+            && !ReplUtils.includeAcidTableInDump(conf)) {
+      return false;
+    }
+
+    return true;
+  }
+
   private Long incrementalDump(Path dumpRoot, DumpMetaData dmd, Path cmRoot, Hive hiveDb) throws Exception {
     Long lastReplId;// get list of events matching dbPattern & tblPattern
     // go through each event, and dump out each event to a event-level dump dir inside dumproot
     String validTxnList = null;
     long waitUntilTime = 0;
     long bootDumpBeginReplId = -1;
 
+    List<String> tableList = work.replScope.includeAllTables() ? null : new ArrayList<>();
 
 Review comment:
   yes ..if file is not present then they assume it to be db level replicattiion

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org