You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2012/08/24 20:51:52 UTC
svn commit: r1377045 - in /jmeter/trunk:
src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
xdocs/changes.xml
Author: pmouawad
Date: Fri Aug 24 18:51:51 2012
New Revision: 1377045
URL: http://svn.apache.org/viewvc?rev=1377045&view=rev
Log:
Bug 52266 - Code:Inconsistent synchronization
Bugzilla Id: 52266
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java?rev=1377045&r1=1377044&r2=1377045&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java Fri Aug 24 18:51:51 2012
@@ -227,7 +227,10 @@ implements ActionListener, TreeSelection
/** {@inheritDoc} */
public void valueChanged(TreeSelectionEvent e) {
lastSelectionEvent = e;
- DefaultMutableTreeNode node = (DefaultMutableTreeNode) jTree.getLastSelectedPathComponent();
+ DefaultMutableTreeNode node = null;
+ synchronized (this) {
+ node = (DefaultMutableTreeNode) jTree.getLastSelectedPathComponent();
+ }
if (node != null) {
// to restore last tab used
Modified: jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java?rev=1377045&r1=1377044&r2=1377045&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java (original)
+++ jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java Fri Aug 24 18:51:51 2012
@@ -115,8 +115,10 @@ public class DataSourceElement extends A
@Override
public Object clone() {
DataSourceElement el = (DataSourceElement) super.clone();
- el.excaliburSource = excaliburSource;
- el.perThreadPoolSet = perThreadPoolSet;
+ synchronized (this) {
+ el.excaliburSource = excaliburSource;
+ el.perThreadPoolSet = perThreadPoolSet;
+ }
return el;
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1377045&r1=1377044&r2=1377045&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Fri Aug 24 18:51:51 2012
@@ -119,6 +119,7 @@ Shortcut for Function Helper Dialog is n
<li><bugzilla>53520</bugzilla> - JSR223 Elements : Use Compilable interface to improve performances on File scripts</li>
<li><bugzilla>53501</bugzilla> - Synchronization timer blocks test end.</li>
<li><bugzilla>53750</bugzilla> - TestCompiler saves unnecessary entries in pairing collection</li>
+<li><bugzilla>52266</bugzilla> - Code:Inconsistent synchronization</li>
</ul>
<!-- =================== Improvements =================== -->