[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10077: chore(metricoption): remove metricoption and columntypelable dependency

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10077:
URL: https://github.com/apache/incubator-superset/pull/10077#discussion_r441659131



##########
File path: superset-frontend/src/explore/components/MetricDefinitionValue.jsx
##########
@@ -19,10 +19,10 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 
+import { MetricOption } from '@superset-ui/control-utils';

Review comment:
       nit, group this with the above imports

##########
File path: superset-frontend/src/explore/components/AggregateOption.jsx
##########
@@ -19,7 +19,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 
-import ColumnTypeLabel from '../../components/ColumnTypeLabel';
+import { ColumnTypeLabel } from '@superset-ui/control-utils';

Review comment:
       nit, group this with the above imports

##########
File path: superset-frontend/spec/javascripts/explore/components/MetricDefinitionOption_spec.jsx
##########
@@ -20,9 +20,8 @@ import React from 'react';
 import configureStore from 'redux-mock-store';
 import { shallow } from 'enzyme';
 
-import { ColumnOption } from '@superset-ui/control-utils';
+import { ColumnOption, MetricOption } from '@superset-ui/control-utils';

Review comment:
       nit, group this with the above imports
   
   

##########
File path: superset-frontend/src/explore/components/AdhocMetricStaticOption.jsx
##########
@@ -19,7 +19,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 
-import ColumnTypeLabel from '../../components/ColumnTypeLabel';
+import { ColumnTypeLabel } from '@superset-ui/control-utils';

Review comment:
       nit, group this with the above imports
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org