[jira] [Commented] (MESOS-2487) Ensure protobuf "==" operator does not go out of sync with new protobuf fields

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341925#comment-16341925 ] 

Benjamin Mahler commented on MESOS-2487:
----------------------------------------

An update: When looking at a recent review introducing another operator, I noticed protobuf now provides a {{MessageDifferencer}}:
https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.util.message_differencer

This has pretty nice functionality:
* Custom ignore criteria
* Ability to treat fields as sets, lists, or maps
* Reporting of differences

This could replace the majority of our custom ones! cc [~kaysoky]

> Ensure protobuf "==" operator does not go out of sync with new protobuf fields
> ------------------------------------------------------------------------------
>
>                 Key: MESOS-2487
>                 URL: https://issues.apache.org/jira/browse/MESOS-2487
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Vinod Kone
>            Priority: Major
>
> Currently when a new field is added to a protobuf that has a custom "==" operator defined,  we don't make sure that the field is accounted for in the comparison. Ideally we should catch such errors at build time or 'make check' time. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)