You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2003/02/19 20:58:58 UTC

svn rev 4965: FAIL (i686-pc-win32-winxp static ra_local) (branches/release-0.18)

Testing Release configuration on local repository.
Running all tests in hashdump-test.exe...success
Running all tests in stringtest.exe...success
Running all tests in path-test.exe...success
Running all tests in stream-test.exe...success
Running all tests in time-test.exe...success
Running all tests in translate-test.exe...success
Running all tests in diff-diff3-test.exe...success
Running all tests in random-test.exe...success
Running all tests in target-test.py...success
Running all tests in run-fs-tests.py...success
Running all tests in run-repos-tests.py...success
Running all tests in getopt_tests.py...success
Running all tests in basic_tests.py...success
Running all tests in commit_tests.py...FAILURE
Running all tests in update_tests.py...success
Running all tests in switch_tests.py...success
Running all tests in prop_tests.py...success
Running all tests in schedule_tests.py...success
Running all tests in log_tests.py...success
Running all tests in copy_tests.py...success
Running all tests in diff_tests.py...success
Running all tests in externals_tests.py...success
Running all tests in merge_tests.py...success
Running all tests in stat_tests.py...success
Running all tests in trans_tests.py...success
Running all tests in svnadmin_tests.py...success
Running all tests in svnlook_tests.py...success
Running all tests in svnversion_tests.py...success
At least one test FAILED, checking C:\Home\brane\src\svn\repo\tests.log
FAIL:  commit_tests.py 16: commit files and dirs with URI-unsafe characters
At least one test was SKIPPED, checking C:\Home\brane\src\svn\repo\tests.log
SKIP:  basic_tests.py 16: basic import of executable files
SKIP:  commit_tests.py 26: committing a symlink should fail
SKIP:  prop_tests.py 11: set and get a revprop change
SKIP:  schedule_tests.py 4: schedule: add some executable files
SKIP:  schedule_tests.py 10: revert: add some executable files
SKIP:  schedule_tests.py 16: commit: add some executable files
SKIP:  copy_tests.py 11: executable bit should be preserved when copying
SKIP:  merge_tests.py 5: merge one file, receive a specific error
SKIP:  stat_tests.py 6: status with versioned items replaced by symbolic links

FAIL: win-tests.py

Re: svn rev 4965: FAIL (i686-pc-win32-winxp static ra_local) (branches/release-0.18)

Posted by Branko Čibej <br...@xbc.nu>.
cmpilato@collab.net wrote:

>=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <br...@xbc.nu> writes:
>
>  
>
>>Michael Price wrote:
>>
>>    
>>
>>>Branko $,1 ,(Bibej writes:
>>>      
>>>
>>>>Running all tests in commit_tests.py...FAILURE
>>>>
>>>>[snip]
>>>>
>>>>At least one test FAILED, checking C:\Home\brane\src\svn\repo\tests.log
>>>>FAIL:  commit_tests.py 16: commit files and dirs with URI-unsafe characters
>>>>        
>>>>
>>>I'm testing ra_local on linux and solaris at the moment. Linux passed
>>>this test. Solaris is still compiling.
>>>
>>>      
>>>
>>>>FAIL: win-tests.py
>>>>        
>>>>
>>>Alas, I have no Windows-foo.
>>> 
>>>
>>>      
>>>
>>I think Windows simply doesn't allow files with control chars (tabs, in
>>this case) in the names. We may have to extract this subtest into its
>>own test and skip it on Windows.
>>    
>>
>
>Nono.  Don't skip the whole test -- just specialize tab_path with the
>other couple of ugly paths.
>
What I meant was have a separate test for the tab thing -- but you're
right, special-casing is better here. Youre patch looks fine, go ahead
and commit it. I don't thing it has to go on the branch, though.


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn rev 4965: FAIL (i686-pc-win32-winxp static ra_local) (branches/release-0.18)

Posted by cm...@collab.net.
=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <br...@xbc.nu> writes:

> Michael Price wrote:
> 
> >Branko $,1 ,(Bibej writes:
> > > Running all tests in commit_tests.py...FAILURE
> > >
> > > [snip]
> > >
> > > At least one test FAILED, checking C:\Home\brane\src\svn\repo\tests.log
> > > FAIL:  commit_tests.py 16: commit files and dirs with URI-unsafe characters
> >
> >I'm testing ra_local on linux and solaris at the moment. Linux passed
> >this test. Solaris is still compiling.
> >
> > > FAIL: win-tests.py
> >
> >Alas, I have no Windows-foo.
> >  
> >
> 
> I think Windows simply doesn't allow files with control chars (tabs, in
> this case) in the names. We may have to extract this subtest into its
> own test and skip it on Windows.

Nono.  Don't skip the whole test -- just specialize tab_path with the
other couple of ugly paths.

Index: commit_tests.py
===================================================================
--- commit_tests.py	(revision 4957)
+++ commit_tests.py	(working copy)
@@ -1040,15 +1040,17 @@
   if svntest.main.windows:
     angle_name = '$angle$'
     nasty_name = '#![]{}()$$%'
+    tab_name   = 'tab-name'
   else:
     angle_name = '<angle>'
     nasty_name = '#![]{}()<>%'
-
+    tab_name   = "tab\tname"
+    
   # Make some convenient paths.
   hash_dir = os.path.join(wc_dir, '#hash#')
   nasty_dir = os.path.join(wc_dir, nasty_name)
   space_path = os.path.join(wc_dir, 'A', 'D', 'space path')
-  tab_path = os.path.join(wc_dir, 'A', 'D', 'G', "tab\tpath")
+  tab_path = os.path.join(wc_dir, 'A', 'D', 'G', tab_name)
   bang_path = os.path.join(wc_dir, 'A', 'D', 'H', 'bang!')
   bracket_path = os.path.join(wc_dir, 'A', 'D', 'H', 'bra[ket')
   brace_path = os.path.join(wc_dir, 'A', 'D', 'H', 'bra{e')

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn rev 4965: FAIL (i686-pc-win32-winxp static ra_local) (branches/release-0.18)

Posted by Branko Čibej <br...@xbc.nu>.
Michael Price wrote:

>Branko $,1 ,(Bibej writes:
> > Running all tests in commit_tests.py...FAILURE
> >
> > [snip]
> >
> > At least one test FAILED, checking C:\Home\brane\src\svn\repo\tests.log
> > FAIL:  commit_tests.py 16: commit files and dirs with URI-unsafe characters
>
>I'm testing ra_local on linux and solaris at the moment. Linux passed
>this test. Solaris is still compiling.
>
> > FAIL: win-tests.py
>
>Alas, I have no Windows-foo.
>  
>

I think Windows simply doesn't allow files with control chars (tabs, in
this case) in the names. We may have to extract this subtest into its
own test and skip it on Windows.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org