You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/31 00:35:25 UTC

[GitHub] [cordova-android] erisu opened a new pull request #1190: Revert "feat: upgrade gradle@6.8.3"

erisu opened a new pull request #1190:
URL: https://github.com/apache/cordova-android/pull/1190


   Reverts apache/cordova-android#1174
   
   Sorry, it seems some people do not trust that this follows semver and feels it may not fit a minor release.
   We will revert this PR and would like it resubmitted for the major release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io edited a comment on pull request #1190: Revert "feat: upgrade gradle@6.8.3"

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1190:
URL: https://github.com/apache/cordova-android/pull/1190#issuecomment-810680524


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=h1) Report
   > Merging [#1190](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=desc) (abf5ece) into [master](https://codecov.io/gh/apache/cordova-android/commit/1f5426f939693c42ebe7d14bfb5e52bdbd61c25a?el=desc) (1f5426f) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1190/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1190   +/-   ##
   =======================================
     Coverage   73.36%   73.36%           
   =======================================
     Files          22       22           
     Lines        1772     1772           
   =======================================
     Hits         1300     1300           
     Misses        472      472           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1190/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=footer). Last update [1f5426f...abf5ece](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] erisu merged pull request #1190: Revert "feat: upgrade gradle@6.8.3"

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1190:
URL: https://github.com/apache/cordova-android/pull/1190


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-android] codecov-io commented on pull request #1190: Revert "feat: upgrade gradle@6.8.3"

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1190:
URL: https://github.com/apache/cordova-android/pull/1190#issuecomment-810680524


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=h1) Report
   > Merging [#1190](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=desc) (abf5ece) into [master](https://codecov.io/gh/apache/cordova-android/commit/1f5426f939693c42ebe7d14bfb5e52bdbd61c25a?el=desc) (1f5426f) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1190/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1190   +/-   ##
   =======================================
     Coverage   73.36%   73.36%           
   =======================================
     Files          22       22           
     Lines        1772     1772           
   =======================================
     Hits         1300     1300           
     Misses        472      472           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1190/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=footer). Last update [1f5426f...abf5ece](https://codecov.io/gh/apache/cordova-android/pull/1190?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org