You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/02/22 21:20:46 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #4432: Fix broken
ORT caching resulting in malformed config files
rob05c opened a new pull request #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432
Fixes ORT caching to CBOR. The current Gob encoding is fundamentally broken. See https://github.com/golang/go/issues/4609 . It's not isomorphic: it does not decode what in encodes. In practical terms, default values like 0 become null pointers, resulting in missing remap lines in the config.
This changes the default to CBOR, which is an IETF RFC standard. See https://tools.ietf.org/html/rfc7049 .
It also adds a unit test, to verify the default cache format is isomorphic. Gob fails the test, CBOR and JSON pass it.
Includes tests. No docs, no changelog, no interface change.
- [x] This PR fixes is not related to any other Issue
## Which Traffic Control components are affected by this PR?
- Traffic Ops ORT
## What is the best way to verify this PR?
Run unit tests.
Generate remap.config with assigned delivery services of type "HTTP" (which is represented by `0`, the default int value). Without this fix, remap lines will be missing. With fix, config file should have appropriate remap lines for HTTP DSes.
## If this is a bug fix, what versions of Traffic Control are affected?
- master
- 4.0.x
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rob05c commented on issue #4432: Fix broken ORT
caching resulting in malformed config files
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432#issuecomment-590001625
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rob05c closed pull request #4432: Fix broken ORT
caching resulting in malformed config files
Posted by GitBox <gi...@apache.org>.
rob05c closed pull request #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rob05c commented on issue #4432: Fix broken ORT
caching resulting in malformed config files
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432#issuecomment-590127752
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rob05c commented on issue #4432: Fix broken ORT
caching resulting in malformed config files
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432#issuecomment-590378099
Ah. I was not aware of that :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rob05c commented on issue #4432: Fix broken ORT
caching resulting in malformed config files
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432#issuecomment-590428569
Closing in lieu of #4433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rob05c commented on issue #4432: Fix broken ORT
caching resulting in malformed config files
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #4432: Fix broken ORT caching resulting in malformed config files
URL: https://github.com/apache/trafficcontrol/pull/4432#issuecomment-590126914
Ok, I added updating the Go build version to 1.12 to this PR. I tested building, installing, and running the compiled binaries, on both TO and ORT.
I also created a PR using JSON instead of CBOR, which make ORT ~50% slower, but doesn't require updating Go to 1.12, see #4433 . I'll let the community decide which to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services