You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/21 14:50:10 UTC

[GitHub] [skywalking] lijial commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode

lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749011710


   > Oh, this is a very serious bug we haven't detected for a very long time. Actually, the issue is, strategy determines the channel implementation. In the `if_possible`, should be `Buffer` rather than `ArrayBlockingQueueBuffer`.
   > 
   > So, the change should be **remove** `DataCarrier#setBufferStrategy` method, and require `BufferStrategy` in the constructor.
   > 
   > Are you willing to fix this issue?
   
   I'm willing to fix the issue, I would pull add commit a pr later, thank you for give me the chance


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org