You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/29 14:36:01 UTC
[GitHub] [incubator-nuttx-apps] v01d opened a new pull request #510: LVGL: use NuttX's printf()
v01d opened a new pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510
## Summary
This makes LVGL use NuttX's printf facilities instead of its own
## Impact
LVGL
## Testing
Various LVGL configs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735448327
@v01d can you just add `-Wno-format-signedness` to CFLAGS in the Makefile in `graphics/lvgl/`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735532485
That needs to also be done for `examples/lvgldemo/Makefile` since that also is external code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d commented on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735449168
> @v01d can you just add `-Wno-format-signedness` to CFLAGS in the Makefile in `graphics/lvgl/`
Thanks, I added the flag, hopefully that fixes the error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d commented on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735407853
It seems the more strict checking of printf() formatting now affects third-party packages. @yamt how can I disable this for third-party code build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton edited a comment on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735456605
@v01d Looks like it is more than just the sign issue with the format string (uint32 vs int). I did this change and everything built fine (on top of your lvgl improvement).
```c
diff --git a/graphics/lvgl/Make.defs b/graphics/lvgl/Make.defs
index 681b8f4f..96c203a5 100644
--- a/graphics/lvgl/Make.defs
+++ b/graphics/lvgl/Make.defs
@@ -36,6 +36,7 @@
ifeq ($(CONFIG_GRAPHICS_LVGL),y)
CONFIGURED_APPS += $(APPDIR)/graphics/lvgl
+CFLAGS += "-Wno-format"
# It allows `<lvgl/lvgl.h>` import.
```
```
./tools/configure.sh stm32f429i-disco:lvgl
make EXTRAFLAGS="-Wno-cpp -Werror"
```
That is the underlying make argument that the CI system uses btw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] v01d commented on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735469541
Thanks, I just pushed the suggested flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #510: LVGL: use NuttX's printf()
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #510:
URL: https://github.com/apache/incubator-nuttx-apps/pull/510#issuecomment-735456605
@v01d Looks like it is more than just the sign issue with the format string (uint32 vs int). I did this change and everything built fine.
```c
diff --git a/graphics/lvgl/Make.defs b/graphics/lvgl/Make.defs
index 681b8f4f..96c203a5 100644
--- a/graphics/lvgl/Make.defs
+++ b/graphics/lvgl/Make.defs
@@ -36,6 +36,7 @@
ifeq ($(CONFIG_GRAPHICS_LVGL),y)
CONFIGURED_APPS += $(APPDIR)/graphics/lvgl
+CFLAGS += "-Wno-format"
# It allows `<lvgl/lvgl.h>` import.
```
```
./tools/configure.sh stm32f429i-disco:lvgl
make EXTRAFLAGS="-Wno-cpp -Werror"
```
That is the underlying make argument that the CI system uses btw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org