You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/19 03:50:55 UTC
[GitHub] [dubbo-go] sxllwx opened a new pull request #520: Feature: CI with Docker
sxllwx opened a new pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Use docker as an infrastructure provider, docker provides dependent third-party components such as Zookeeper, etcdv3, nacos, and consul. Reduce the complexity of Mock in unit testing.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
WIP, it is still being tested and modified, and cannot be merged directly at this time.
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.45% -0.04%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6461 -3
- Misses 2618 2623 +5
+ Partials 641 639 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...496610a](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427862417
##########
File path: test/integrate/dubbo/go-client/client.yml
##########
@@ -0,0 +1,61 @@
+# dubbo client yaml configure file
+
+
+check: true
+# client
+request_timeout : "3s"
+# connect timeout
+connect_timeout : "3s"
+
+# application config
+application:
+ organization : "ikurento.com"
+ name : "BDTService"
+ module : "dubbogo user-info client"
+ version : "0.0.1"
+ owner : "ZX"
+ environment : "dev"
+
+registries :
+ "demoZk":
+ protocol: "zookeeper"
+ timeout : "3s"
+ address: "127.0.0.1:2181"
+ username: ""
+ password: ""
+
+
+references:
+ "UserProvider":
+ # 可以指定多个registry，使用逗号隔开;不指定默认向所有注册中心注册
+ registry: "demoZk"
+ protocol : "dubbo"
+ interface : "com.ikurento.user.UserProvider"
+ cluster: "failover"
+ methods :
+ - name: "GetUser"
+ retries: 3
+
+
+protocol_conf:
+ dubbo:
+ reconnect_interval: 0
+ connection_number: 2
+ heartbeat_period: "5s"
+ session_timeout: "20s"
+ pool_size: 64
+ pool_ttl: 600
+ getty_session_param:
+ compress_encoding: false
+ tcp_no_delay: true
+ tcp_keep_alive: true
+ keep_alive_period: "120s"
+ tcp_r_buf_size: 262144
+ tcp_w_buf_size: 65536
+ pkg_rq_size: 1024
+ pkg_wq_size: 512
+ tcp_read_timeout: "1s"
+ tcp_write_timeout: "5s"
+ wait_timeout: "1s"
+ max_msg_len: 10240
Review comment:
Okay, I have modified it in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...06a543b](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...385f267](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx closed pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx closed pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.40% -0.08%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6457 -7
- Misses 2618 2626 +8
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...b39f876](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.40% -0.08%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6457 -7
- Misses 2618 2626 +8
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...8e9c2b2](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...f83dade](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.45% -0.04%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6461 -3
- Misses 2618 2623 +5
+ Partials 641 639 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...b6a5888](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427708491
##########
File path: test/integrate/dubbo/go-server/Dockerfile
##########
@@ -0,0 +1,20 @@
+FROM golang
Review comment:
Okay, I have modified it in the latest commit.
##########
File path: test/integrate/dubbo/go-client/Dockerfile
##########
@@ -0,0 +1,21 @@
+FROM golang
Review comment:
Okay, I have modified it in the latest commit.
##########
File path: test/integrate/dubbo/go-client/Dockerfile
##########
@@ -0,0 +1,21 @@
+FROM golang
+
+MAINTAINER scottwangsxll@gmail.com
Review comment:
Okay, I have modified it in the latest commit.
##########
File path: test/integrate/dubbo/go-client/go.mod
##########
@@ -0,0 +1,3 @@
+module github.com/apache/dubbo-go/test/integrate/dubbo/go-client
+
+go 1.14
Review comment:
Okay, I have modified it in the latest commit.
##########
File path: test/integrate/dubbo/go-server/go.mod
##########
@@ -0,0 +1,3 @@
+module github.com/apache/dubbo-go/test/integrate/dubbo/go-server
+
+go 1.14
Review comment:
Okay, I have modified it in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
zouyx edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630909077
> > what
>
> test / integrate is a sample developed separately for integration testing and works similar to helloworld, using this project as a test sample in the Dockerfile for integration testing. The Server quits after accepting a Client connection and completes a complete interaction, and the Client quits after making a request to the Server and getting a return。 @zouyx
In my opion. That should be a integration test . So move it to https://github.com/apache/dubbo-samples/tree/master/golang will better.
What do you think? @hxmhlt @fangyincheng @flycash
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
zouyx commented on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630909077
> > what
>
> test / integrate is a sample developed separately for integration testing and works similar to helloworld, using this project as a test sample in the Dockerfile for integration testing. The Server quits after accepting a Client connection and completes a complete interaction, and the Client quits after making a request to the Server and getting a return。 @zouyx
In my opion. That should be a integration test . So move it to https://github.com/apache/dubbo-samples/tree/master/golang will better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
+ Coverage 66.48% 66.80% +0.31%
===========================================
Files 184 184
Lines 9723 9723
===========================================
+ Hits 6464 6495 +31
+ Misses 2618 2588 -30
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <0.00%> (+3.73%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `62.90% <0.00%> (+5.37%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (+9.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...8e9c2b2](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427862247
##########
File path: test/integrate/dubbo/go-server/user.go
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "time"
+)
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+ "github.com/apache/dubbo-go/config"
+)
+
+func init() {
+ config.SetProviderService(new(UserProvider))
+ // ------for hessian2------
+ hessian.RegisterPOJO(&User{})
+}
+
+type User struct {
+ Id string
+ Name string
+ Age int32
+ Time time.Time
+}
+
+type UserProvider struct {
+}
+
+func (u *UserProvider) GetUser(ctx context.Context, req []interface{}) (*User, error) {
+ println("req:%#v", req)
Review comment:
Okay, I have modified it in the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630903533
> what
test / integrate is a sample developed separately for integration testing and works similar to helloworld, using this project as a test sample in the Dockerfile for integration testing. The Server quits after accepting a Client connection and completes a complete interaction, and the Client quits after making a request to the Server and getting a return。 @zouyx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.45% -0.04%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6461 -3
- Misses 2618 2623 +5
+ Partials 641 639 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...47b9666](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...9a68bb4](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630913010
> I am not sure what `test/integrate` will use for ?
> > > what
> >
> >
> > test / integrate is a sample developed separately for integration testing and works similar to helloworld, using this project as a test sample in the Dockerfile for integration testing. The Server quits after accepting a Client connection and completes a complete interaction, and the Client quits after making a request to the Server and getting a return。 @zouyx
>
> In my opion. That should be a integration test . So move it to https://github.com/apache/dubbo-samples/tree/master/golang will better.
>
> What do you think? @hxmhlt @fangyincheng @flycash
> > > what
> >
> >
> > test / integrate is a sample developed separately for integration testing and works similar to helloworld, using this project as a test sample in the Dockerfile for integration testing. The Server quits after accepting a Client connection and completes a complete interaction, and the Client quits after making a request to the Server and getting a return。 @zouyx
>
> In my opion. That should be a integration test . So move it to https://github.com/apache/dubbo-samples/tree/master/golang will better.
>
> What do you think? @hxmhlt @fangyincheng @flycash
> > > what
> >
> >
> > test / integrate is a sample developed separately for integration testing and works similar to helloworld, using this project as a test sample in the Dockerfile for integration testing. The Server quits after accepting a Client connection and completes a complete interaction, and the Client quits after making a request to the Server and getting a return。 @zouyx
>
> In my opion. That should be a integration test . So move it to https://github.com/apache/dubbo-samples/tree/master/golang will better.
>
> What do you think? @hxmhlt @fangyincheng @flycash
I have considered this solution before, but because cross-code repo collaboration is more difficult to do, and integration testing needs to be based on the code of the Fork repo in the specific PR. This form of CI is more difficult.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427854085
##########
File path: .travis.yml
##########
@@ -1,23 +1,47 @@
-language: go
+dist: trusty
+sudo: required
+# define the dependence env
+language: go
os:
- linux
-
go:
- "1.13"
-
+services:
+ - docker
env:
- GO111MODULE=on
-
install: true
+# define ci-stage
script:
+ # license-check
+ - echo 'start license check'
- go fmt ./... && [[ -z `git status -s` ]]
- sh before_validate_license.sh
- chmod u+x /tmp/tools/license/license-header-checker
- /tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]
+ # unit-test
+ - echo 'start unit-test'
- chmod u+x before_ut.sh && ./before_ut.sh
- go mod vendor && go test ./... -coverprofile=coverage.txt -covermode=atomic
+ # integrate-test
+ - echo 'start integrate-test'
+ # start zookeeper registry insecure listen in [:]:2181
+ - docker run -d --network host zookeeper
+ - ROOTDIR=$(pwd)
+ - cd ./test/integrate/dubbo/go-client && docker build . -t ci-consumer --build-arg PR_ORIGIN_REPO=${TRAVIS_PULL_REQUEST_SLUG} --build-arg PR_ORIGIN_COMMITID=${TRAVIS_PULL_REQUEST_SHA} && cd $ROOTDIR
+ - cd ./test/integrate/dubbo/go-server && docker build . -t ci-provider --build-arg PR_ORIGIN_REPO=${TRAVIS_PULL_REQUEST_SLUG} --build-arg PR_ORIGIN_COMMITID=${TRAVIS_PULL_REQUEST_SHA} && cd $ROOTDIR
+ - docker run -d --network host ci-provider
+ - docker run -it --network host ci-consumer
Review comment:
if ci-provider not boot completed, the ci flow will faild, zookeeper container have sample problem. but our registry will retry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427708985
##########
File path: test/integrate/dubbo/go-server/user.go
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "time"
+)
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+ "github.com/apache/dubbo-go/config"
+)
+
+func init() {
+ config.SetProviderService(new(UserProvider))
+ // ------for hessian2------
+ hessian.RegisterPOJO(&User{})
+}
+
+type User struct {
+ Id string
+ Name string
+ Age int32
+ Time time.Time
+}
+
+type UserProvider struct {
+}
+
+func (u *UserProvider) GetUser(ctx context.Context, req []interface{}) (*User, error) {
+ println("req:%#v", req)
Review comment:
I don't think the code here should be hard-coded. result depend consumer impl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.27% -0.21%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6444 -20
- Misses 2618 2641 +23
+ Partials 641 638 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0.00%> (-3.64%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.88% <0.00%> (-1.83%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `56.45% <0.00%> (-1.08%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...dc27a11](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...b6a5888](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.27% -0.21%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6444 -20
- Misses 2618 2641 +23
+ Partials 641 638 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0.00%> (-3.64%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.88% <0.00%> (-1.83%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `56.45% <0.00%> (-1.08%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...dc27a11](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427419710
##########
File path: test/integrate/dubbo/go-client/go.mod
##########
@@ -0,0 +1,3 @@
+module github.com/apache/dubbo-go/test/integrate/dubbo/go-client
+
+go 1.14
Review comment:
in main package go version is 1.13 , should u change it? if not , may cause compile problem.
https://github.com/apache/dubbo-go/blob/master/go.mod
##########
File path: test/integrate/dubbo/go-server/go.mod
##########
@@ -0,0 +1,3 @@
+module github.com/apache/dubbo-go/test/integrate/dubbo/go-server
+
+go 1.14
Review comment:
in main package go version is 1.13 , should u change it? if not , may cause compile problem.
https://github.com/apache/dubbo-go/blob/master/go.mod
##########
File path: test/integrate/dubbo/go-client/Dockerfile
##########
@@ -0,0 +1,21 @@
+FROM golang
+
+MAINTAINER scottwangsxll@gmail.com
Review comment:
what is it mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...c109d8f](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427708902
##########
File path: test/integrate/dubbo/go-client/client.go
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "time"
+)
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+ _ "github.com/apache/dubbo-go/common/proxy/proxy_factory"
+ "github.com/apache/dubbo-go/config"
+ _ "github.com/apache/dubbo-go/protocol/dubbo"
+ _ "github.com/apache/dubbo-go/registry/protocol"
+
+ _ "github.com/apache/dubbo-go/filter/filter_impl"
+
+ _ "github.com/apache/dubbo-go/cluster/cluster_impl"
+ _ "github.com/apache/dubbo-go/cluster/loadbalance"
+ _ "github.com/apache/dubbo-go/registry/zookeeper"
+)
+
+var (
+ survivalTimeout int = 10e9
+)
+
+func println(format string, args ...interface{}) {
+ fmt.Printf("\033[32;40m"+format+"\033[0m\n", args...)
+}
+
+// they are necessary:
+// export CONF_CONSUMER_FILE_PATH="xxx"
+// export APP_LOG_CONF_FILE="xxx"
+func main() {
+ hessian.RegisterPOJO(&User{})
+ config.Load()
+ time.Sleep(3e9)
+
+ println("\n\n\nstart to test dubbo")
+
+ go func() {
+ select {
+ case <-time.After(time.Minute):
+ panic("provider not start after client already running 1min")
+ }
+ }()
+ user := &User{}
+ err := userProvider.GetUser(context.TODO(), []interface{}{"A001"}, user)
+ if err != nil {
+ panic(err)
+ }
+ println("response result: %v\n", user)
Review comment:
I don't think the code here should be hard-coded. result depend provider impl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
+ Coverage 66.48% 66.80% +0.31%
===========================================
Files 184 184
Lines 9723 9723
===========================================
+ Hits 6464 6495 +31
+ Misses 2618 2588 -30
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <0.00%> (+3.73%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `62.90% <0.00%> (+5.37%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (+9.37%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...dc27a11](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.40% -0.08%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6457 -7
- Misses 2618 2626 +8
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...a519203](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...dc27a11](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427442649
##########
File path: test/integrate/dubbo/go-client/Dockerfile
##########
@@ -0,0 +1,21 @@
+FROM golang
Review comment:
is licence necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] pantianying commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
pantianying commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427714512
##########
File path: test/integrate/dubbo/go-client/client.yml
##########
@@ -0,0 +1,61 @@
+# dubbo client yaml configure file
+
+
+check: true
+# client
+request_timeout : "3s"
+# connect timeout
+connect_timeout : "3s"
+
+# application config
+application:
+ organization : "ikurento.com"
+ name : "BDTService"
+ module : "dubbogo user-info client"
+ version : "0.0.1"
+ owner : "ZX"
+ environment : "dev"
+
+registries :
+ "demoZk":
+ protocol: "zookeeper"
+ timeout : "3s"
+ address: "127.0.0.1:2181"
+ username: ""
+ password: ""
+
+
+references:
+ "UserProvider":
+ # 可以指定多个registry，使用逗号隔开;不指定默认向所有注册中心注册
+ registry: "demoZk"
+ protocol : "dubbo"
+ interface : "com.ikurento.user.UserProvider"
+ cluster: "failover"
+ methods :
+ - name: "GetUser"
+ retries: 3
+
+
+protocol_conf:
+ dubbo:
+ reconnect_interval: 0
+ connection_number: 2
+ heartbeat_period: "5s"
+ session_timeout: "20s"
+ pool_size: 64
+ pool_ttl: 600
+ getty_session_param:
+ compress_encoding: false
+ tcp_no_delay: true
+ tcp_keep_alive: true
+ keep_alive_period: "120s"
+ tcp_r_buf_size: 262144
+ tcp_w_buf_size: 65536
+ pkg_rq_size: 1024
+ pkg_wq_size: 512
+ tcp_read_timeout: "1s"
+ tcp_write_timeout: "5s"
+ wait_timeout: "1s"
+ max_msg_len: 10240
Review comment:
this can be bigger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
Patrick0308 commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427809683
##########
File path: test/integrate/dubbo/go-client/client.go
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "time"
+)
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+ _ "github.com/apache/dubbo-go/common/proxy/proxy_factory"
+ "github.com/apache/dubbo-go/config"
+ _ "github.com/apache/dubbo-go/protocol/dubbo"
+ _ "github.com/apache/dubbo-go/registry/protocol"
+
+ _ "github.com/apache/dubbo-go/filter/filter_impl"
+
+ _ "github.com/apache/dubbo-go/cluster/cluster_impl"
+ _ "github.com/apache/dubbo-go/cluster/loadbalance"
+ _ "github.com/apache/dubbo-go/registry/zookeeper"
+)
+
+var (
+ survivalTimeout int = 10e9
+)
+
+func println(format string, args ...interface{}) {
+ fmt.Printf("\033[32;40m"+format+"\033[0m\n", args...)
+}
+
+// they are necessary:
+// export CONF_CONSUMER_FILE_PATH="xxx"
+// export APP_LOG_CONF_FILE="xxx"
+func main() {
+ hessian.RegisterPOJO(&User{})
+ config.Load()
+ time.Sleep(3e9)
+
+ println("\n\n\nstart to test dubbo")
+
+ go func() {
+ select {
+ case <-time.After(time.Minute):
+ panic("provider not start after client already running 1min")
+ }
+ }()
+ user := &User{}
+ err := userProvider.GetUser(context.TODO(), []interface{}{"A001"}, user)
+ if err != nil {
+ panic(err)
+ }
+ println("response result: %v\n", user)
Review comment:
I agree with @zouyx . I think should make sure the content returned is what we expect.
##########
File path: .travis.yml
##########
@@ -1,23 +1,47 @@
-language: go
+dist: trusty
+sudo: required
+# define the dependence env
+language: go
os:
- linux
-
go:
- "1.13"
-
+services:
+ - docker
env:
- GO111MODULE=on
-
install: true
+# define ci-stage
script:
+ # license-check
+ - echo 'start license check'
- go fmt ./... && [[ -z `git status -s` ]]
- sh before_validate_license.sh
- chmod u+x /tmp/tools/license/license-header-checker
- /tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]
+ # unit-test
+ - echo 'start unit-test'
- chmod u+x before_ut.sh && ./before_ut.sh
- go mod vendor && go test ./... -coverprofile=coverage.txt -covermode=atomic
+ # integrate-test
+ - echo 'start integrate-test'
+ # start zookeeper registry insecure listen in [:]:2181
+ - docker run -d --network host zookeeper
+ - ROOTDIR=$(pwd)
+ - cd ./test/integrate/dubbo/go-client && docker build . -t ci-consumer --build-arg PR_ORIGIN_REPO=${TRAVIS_PULL_REQUEST_SLUG} --build-arg PR_ORIGIN_COMMITID=${TRAVIS_PULL_REQUEST_SHA} && cd $ROOTDIR
+ - cd ./test/integrate/dubbo/go-server && docker build . -t ci-provider --build-arg PR_ORIGIN_REPO=${TRAVIS_PULL_REQUEST_SLUG} --build-arg PR_ORIGIN_COMMITID=${TRAVIS_PULL_REQUEST_SHA} && cd $ROOTDIR
+ - docker run -d --network host ci-provider
+ - docker run -it --network host ci-consumer
Review comment:
`docker run -d --network host ci-provider` run container in background. when `ci-consumer` started, `ci-provider` may be not boot completed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...eb46ba9](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
sxllwx commented on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630903533
> what
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...7a225fc](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...a14978e](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#discussion_r427687915
##########
File path: test/integrate/dubbo/go-server/Dockerfile
##########
@@ -0,0 +1,20 @@
+FROM golang
Review comment:
Lisence?
##########
File path: test/integrate/dubbo/go-client/client.go
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "time"
+)
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+ _ "github.com/apache/dubbo-go/common/proxy/proxy_factory"
+ "github.com/apache/dubbo-go/config"
+ _ "github.com/apache/dubbo-go/protocol/dubbo"
+ _ "github.com/apache/dubbo-go/registry/protocol"
+
+ _ "github.com/apache/dubbo-go/filter/filter_impl"
+
+ _ "github.com/apache/dubbo-go/cluster/cluster_impl"
+ _ "github.com/apache/dubbo-go/cluster/loadbalance"
+ _ "github.com/apache/dubbo-go/registry/zookeeper"
+)
+
+var (
+ survivalTimeout int = 10e9
+)
+
+func println(format string, args ...interface{}) {
+ fmt.Printf("\033[32;40m"+format+"\033[0m\n", args...)
+}
+
+// they are necessary:
+// export CONF_CONSUMER_FILE_PATH="xxx"
+// export APP_LOG_CONF_FILE="xxx"
+func main() {
+ hessian.RegisterPOJO(&User{})
+ config.Load()
+ time.Sleep(3e9)
+
+ println("\n\n\nstart to test dubbo")
+
+ go func() {
+ select {
+ case <-time.After(time.Minute):
+ panic("provider not start after client already running 1min")
+ }
+ }()
+ user := &User{}
+ err := userProvider.GetUser(context.TODO(), []interface{}{"A001"}, user)
+ if err != nil {
+ panic(err)
+ }
+ println("response result: %v\n", user)
Review comment:
should you check result to keep it correct?
##########
File path: test/integrate/dubbo/go-server/user.go
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "context"
+ "fmt"
+ "time"
+)
+
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
+ "github.com/apache/dubbo-go/config"
+)
+
+func init() {
+ config.SetProviderService(new(UserProvider))
+ // ------for hessian2------
+ hessian.RegisterPOJO(&User{})
+}
+
+type User struct {
+ Id string
+ Name string
+ Age int32
+ Time time.Time
+}
+
+type UserProvider struct {
+}
+
+func (u *UserProvider) GetUser(ctx context.Context, req []interface{}) (*User, error) {
+ println("req:%#v", req)
Review comment:
Should you check params to keep it correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.32% -0.16%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6449 -15
- Misses 2618 2632 +14
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (+0.93%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...4866c0c](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #520: Feature: CI with Docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #520:
URL: https://github.com/apache/dubbo-go/pull/520#issuecomment-630599120
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=h1) Report
> Merging [#520](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/173790493e9c06d48d55ad67ee25b26913289a20&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 66.48% 66.45% -0.04%
===========================================
Files 184 184
Lines 9723 9723
===========================================
- Hits 6464 6461 -3
- Misses 2618 2623 +5
+ Partials 641 639 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0.00%> (+2.15%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/520/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `81.27% <0.00%> (+4.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=footer). Last update [1737904...1c20fea](https://codecov.io/gh/apache/dubbo-go/pull/520?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org