You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/11/11 09:28:57 UTC

[GitHub] [zeppelin] xiejiajun opened a new pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem 

xiejiajun opened a new pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264


   ### What is this PR for?
   - The org.eclipse.jetty.websocket.common.WebSocketRemoteEndpoint#blockingWrite method has been to ensure that the websocket sends messages serially by `ReentrantLock` and `WriteBlocket`, so the NotebookSocket.send method does not need to be locked.
   - If we lock the NotebookSocket.send method, the NotebookServer#onClose method will be triggered when the NotebookSocket.send method sends a message abnormally. At this time, if there are other threads that need to send messages through the current Websocket Session to preempt the noteSocketMap lock in the ConnectionManager,  It will trigger a deadlock.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * [ZEPPELIN-5572](https://issues.apache.org/jira/browse/ZEPPELIN-5572)
   
   ### How should this be tested?
   * CI
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer edited a comment on pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem

Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264#issuecomment-976351520


   If no further comments are received, I will merge this PR into master on Thursday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264#issuecomment-976351520


   If no further comments are received, I will merge this PR into the master on Thursday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264#issuecomment-966886217


   I also found deadlocks in the application after JSR356 was adapted for Websocket.
   I think the synchronised is a relic from the [old code](https://github.com/apache/zeppelin/commit/575df6890ea0349314c8f23a5c19c758779ea9f7#diff-dec5ec785ce8a55940664b101105bccd19b2d8c3c335eef5432eb4f8edf063faL69).
   
   I checked the `WebSocketRemoteEndpoint` implementation and you should be right.
   
   This PR LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] xiejiajun commented on pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem

Posted by GitBox <gi...@apache.org>.
xiejiajun commented on pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264#issuecomment-966823997


   > Please rebase to the current master. I have added a hotfix.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264#issuecomment-966286920


   Please rebase to the current master. I have added a hotfix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4264: [ZEPPELIN-5572] resolve the websocket deadlock problem

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4264:
URL: https://github.com/apache/zeppelin/pull/4264


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org