You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "diecui1202 (GitHub)" <gi...@apache.org> on 2018/09/26 10:21:56 UTC
[GitHub] [incubator-dubbo] diecui1202 opened pull request #2564: fix
#2560, use target/test-classes as the basedir
## What is the purpose of the change
fix #2560, use target/test-classes as the basedir
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2564 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] diecui1202 closed pull request #2564: fix
#2560, use target/test-classes as the basedir
Posted by "diecui1202 (GitHub)" <gi...@apache.org>.
[ pull request closed by diecui1202 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2564 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2564: fix
#2560, use target/test-classes as the basedir
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=h1) Report
> Merging [#2564](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/5968f1a3f825ea0c8f8a231870c74d0f1c7b9ac9?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #2564 +/- ##
===========================================
- Coverage 47.4% 47.38% -0.03%
- Complexity 4283 4466 +183
===========================================
Files 557 568 +11
Lines 23698 25731 +2033
Branches 4072 4576 +504
===========================================
+ Hits 11234 12192 +958
- Misses 10730 11665 +935
- Partials 1734 1874 +140
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/com/alibaba/dubbo/rpc/filter/tps/StatItem.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL3Rwcy9TdGF0SXRlbS5qYXZh) | `79.16% <0%> (-15.84%)` | `7% <0%> (ø)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-8.34%)` | `3% <0%> (ø)` | |
| [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3N0YXR1cy9zdXBwb3J0L0xvYWRTdGF0dXNDaGVja2VyLmphdmE=) | `60% <0%> (-6.67%)` | `2% <0%> (ø)` | |
| [...alibaba/dubbo/remoting/transport/CodecSupport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L0NvZGVjU3VwcG9ydC5qYXZh) | `70.83% <0%> (-5.36%)` | `5% <0%> (ø)` | |
| [...n/java/com/alibaba/dubbo/rpc/support/RpcUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvc3VwcG9ydC9ScGNVdGlscy5qYXZh) | `20.27% <0%> (-4.32%)` | `11% <0%> (ø)` | |
| [.../rpc/cluster/router/condition/ConditionRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3JvdXRlci9jb25kaXRpb24vQ29uZGl0aW9uUm91dGVyLmphdmE=) | `71.64% <0%> (-3.95%)` | `33% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/config/ConsumerConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQ29uc3VtZXJDb25maWcuamF2YQ==) | `92.3% <0%> (-3.7%)` | `15% <0%> (ø)` | |
| [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-3.23%)` | `12% <0%> (ø)` | |
| [...bbo/rpc/cluster/loadbalance/RandomLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL1JhbmRvbUxvYWRCYWxhbmNlLmphdmE=) | `50% <0%> (-2.95%)` | `4% <0%> (ø)` | |
| [...libaba/dubbo/rpc/cluster/support/ClusterUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvQ2x1c3RlclV0aWxzLmphdmE=) | `65.95% <0%> (-2.94%)` | `1% <0%> (ø)` | |
| ... and [161 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2564/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=footer). Last update [5968f1a...5137f3b](https://codecov.io/gh/apache/incubator-dubbo/pull/2564?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2564 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org