You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/31 07:47:08 UTC
[GitHub] [pulsar] liudezhi2098 opened a new pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
liudezhi2098 opened a new pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116
Master Issue: #7115
## Motivation
fix by default config , when the content of the sent message is 5M, it will appear that the current topic can no longer send the message.
## Modifications
bookkeeper.con f
```java
# The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G.
nettyMaxFrameSizeBytes=1073741824
```
The default setting is 1G size, I think it should be larger than the broker's
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116#issuecomment-636553898
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116#issuecomment-637178731
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on a change in pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on a change in pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116#discussion_r433059532
##########
File path: conf/bookkeeper.conf
##########
@@ -268,6 +268,9 @@ serverTcpNoDelay=true
# The Recv ByteBuf allocator max buf size.
# byteBufAllocatorSizeMax=1048576
+# The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G.
Review comment:
use 5MB as the default value , will cause problems，can be changed to 5253120（
5242880 + Commands.MESSAGE_SIZE_FRAME_PADDING）
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116#discussion_r433000584
##########
File path: conf/bookkeeper.conf
##########
@@ -268,6 +268,9 @@ serverTcpNoDelay=true
# The Recv ByteBuf allocator max buf size.
# byteBufAllocatorSizeMax=1048576
+# The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G.
Review comment:
@liudezhi2098 It's better to use 5MB as the default value, in order to avoid the change of the default value to break the use of some scenes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116#issuecomment-637498572
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #7116: fix support set nettyMaxFrameSizeBytes on bookeeper config
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #7116:
URL: https://github.com/apache/pulsar/pull/7116#discussion_r432999800
##########
File path: conf/bookkeeper.conf
##########
@@ -268,6 +268,9 @@ serverTcpNoDelay=true
# The Recv ByteBuf allocator max buf size.
# byteBufAllocatorSizeMax=1048576
+# The maximum netty frame size in bytes. Any message received larger than this will be rejeted. Default value is 1G.
Review comment:
```suggestion
# The maximum netty frame size in bytes. Any message received larger than this will be rejected. The default value is 1G.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org