You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/12/20 03:36:01 UTC
[GitHub] incubator-weex pull request #944: [WEEX-173][iOS] fix iconfont draw failed s...
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/944
[WEEX-173][iOS] fix iconfont draw failed sometimes
the order of drawing text and the action of building font-family in javaScript is not reliable,
so the observer needs to be added to every text component which specify the font-family,
when the the custom font download finish, redraw action will compare the font-family with
font-family of text who received notification and then execute redrawing action.
Bug: 173
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex ios-bugfix-text
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #944
----
commit bfbddecf6b5c8ecf16d2df33984f877f6201e70a
Author: acton393 <zh...@...>
Date: 2017-12-20T03:35:13Z
[WEEX-173][iOS] fix iconfont draw failed sometimes
the order of drawing text and the action of building font-family in javaScript is not reliable,
so the observer needs to be added to every text component which specify the font-family,
when the the custom font download finish, redraw action will compare the font-family with
font-family of text who received notification and then execute redrawing action.
Bug: 173
----
---
[GitHub] incubator-weex pull request #944: [WEEX-173][iOS] fix iconfont draw failed s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/944
---
[GitHub] incubator-weex issue #944: [WEEX-173][iOS] fix iconfont draw failed sometime...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/944
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---