You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/26 20:08:46 UTC

[GitHub] [calcite] jh3507 commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…

jh3507 commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…
URL: https://github.com/apache/calcite/pull/1334#discussion_r307893084
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
 ##########
 @@ -425,7 +435,10 @@ public Frame decorrelateRel(Sort rel) {
     RelCollation newCollation = RexUtil.apply(mapping, oldCollation);
 
     final Sort newSort =
-        LogicalSort.create(newInput, newCollation, rel.offset, rel.fetch);
+        (Sort) relBuilder
 
 Review comment:
   I think it is. However, it seems like there is nothing to lose by using RelNode. Changed its type to RelNode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services