You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/23 22:07:26 UTC

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6744: [FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray

junrushao1994 commented on a change in pull request #6744:
URL: https://github.com/apache/incubator-tvm/pull/6744#discussion_r511176089



##########
File path: rust/tvm-rt/src/to_function.rs
##########
@@ -103,8 +103,10 @@ pub trait ToFunction<I, O>: Sized {
                 value = args_list[i];
                 tcode = type_codes_list[i];
                 if tcode == ffi::TVMArgTypeCode_kTVMObjectHandle as c_int
+                    || tcode == ffi::TVMArgTypeCode_kkTVMObjectRValueRefArg as c_int

Review comment:
       looks like there is an extra k 
   ```suggestion
                       || tcode == ffi::TVMArgTypeCode_kTVMObjectRValueRefArg as c_int
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org