You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by "Ju@N" <ju...@gmail.com> on 2020/02/27 09:48:42 UTC

[PROPOSAL]: Include GEODE-7814 in Release 1.12.0

Hello devs,

I'd like to include the fix for GEODE-7814 [1] in release 1.12.0.
The change prevents a huge amount of unnecessary allocation of objects
while sending/receiving messages, improving the overall performance.
The SHA is db86faec699aca67c02325bca22dcd5b913ddfed [2].
Best regards.

[1]: https://issues.apache.org/jira/browse/GEODE-7814
[2]:
https://github.com/apache/geode/commit/db86faec699aca67c02325bca22dcd5b913ddfed

-- 
Ju@N

Re: [PROPOSAL]: Include GEODE-7814 in Release 1.12.0

Posted by Donal Evans <do...@pivotal.io>.
+1

On Thu, Feb 27, 2020, 06:43 Owen Nichols <on...@pivotal.io> wrote:

> +1
>
> On Thu, Feb 27, 2020 at 1:49 AM Ju@N <ju...@gmail.com> wrote:
>
> > Hello devs,
> >
> > I'd like to include the fix for GEODE-7814 [1] in release 1.12.0.
> > The change prevents a huge amount of unnecessary allocation of objects
> > while sending/receiving messages, improving the overall performance.
> > The SHA is db86faec699aca67c02325bca22dcd5b913ddfed [2].
> > Best regards.
> >
> > [1]: https://issues.apache.org/jira/browse/GEODE-7814
> > [2]:
> >
> >
> https://github.com/apache/geode/commit/db86faec699aca67c02325bca22dcd5b913ddfed
> >
> > --
> > Ju@N
> >
>

Re: [PROPOSAL]: Include GEODE-7814 in Release 1.12.0

Posted by Owen Nichols <on...@pivotal.io>.
+1

On Thu, Feb 27, 2020 at 1:49 AM Ju@N <ju...@gmail.com> wrote:

> Hello devs,
>
> I'd like to include the fix for GEODE-7814 [1] in release 1.12.0.
> The change prevents a huge amount of unnecessary allocation of objects
> while sending/receiving messages, improving the overall performance.
> The SHA is db86faec699aca67c02325bca22dcd5b913ddfed [2].
> Best regards.
>
> [1]: https://issues.apache.org/jira/browse/GEODE-7814
> [2]:
>
> https://github.com/apache/geode/commit/db86faec699aca67c02325bca22dcd5b913ddfed
>
> --
> Ju@N
>

Re: [PROPOSAL]: Include GEODE-7814 in Release 1.12.0

Posted by Ernest Burghardt <eb...@pivotal.io>.
There appears to be consensus that this is a critical fix.

The following commit has been brought into release/1.12 as the
critical fix for GEODE-7814:

git cherry-pick -x db86faec699aca67c02325bca22dcd5b913ddfed

GEODE-7814 has been marked as 'resolved in' 1.12.

Regards
EB


On Thu, Feb 27, 2020 at 7:39 AM Bruce Schuchardt <bs...@pivotal.io>
wrote:

> +1
>
> The change Juan has made corrects a problem introduced during membership
> refactoring.  Every cache operation message that's sent allocates several
> objects that used to be held in statics but were moved into instance
> variables at one point.  Juan's change moves these back into static
> variables.
>
> On 2/27/20, 1:49 AM, "Ju@N" <ju...@gmail.com> wrote:
>
>     Hello devs,
>
>     I'd like to include the fix for GEODE-7814 [1] in release 1.12.0.
>     The change prevents a huge amount of unnecessary allocation of objects
>     while sending/receiving messages, improving the overall performance.
>     The SHA is db86faec699aca67c02325bca22dcd5b913ddfed [2].
>     Best regards.
>
>     [1]: https://issues.apache.org/jira/browse/GEODE-7814
>     [2]:
>
> https://github.com/apache/geode/commit/db86faec699aca67c02325bca22dcd5b913ddfed
>
>     --
>     Ju@N
>
>
>
>

Re: [PROPOSAL]: Include GEODE-7814 in Release 1.12.0

Posted by Bruce Schuchardt <bs...@pivotal.io>.
+1

The change Juan has made corrects a problem introduced during membership refactoring.  Every cache operation message that's sent allocates several objects that used to be held in statics but were moved into instance variables at one point.  Juan's change moves these back into static variables.

On 2/27/20, 1:49 AM, "Ju@N" <ju...@gmail.com> wrote:

    Hello devs,
    
    I'd like to include the fix for GEODE-7814 [1] in release 1.12.0.
    The change prevents a huge amount of unnecessary allocation of objects
    while sending/receiving messages, improving the overall performance.
    The SHA is db86faec699aca67c02325bca22dcd5b913ddfed [2].
    Best regards.
    
    [1]: https://issues.apache.org/jira/browse/GEODE-7814
    [2]:
    https://github.com/apache/geode/commit/db86faec699aca67c02325bca22dcd5b913ddfed
    
    -- 
    Ju@N