[GitHub] [netbeans] vieiro commented on pull request #4080: code and test cleaning

[GitBox <gi...@apache.org>]

vieiro commented on PR #4080:
URL: https://github.com/apache/netbeans/pull/4080#issuecomment-1121957029

   > I think @vieiro tried to make the point, that this PR is to much noise for to little gain. Cosmetic changes by us nothing, but take time to review and see where breaks might have been introduced. PRs should fix problems, not cosmetics.
   
   Exactly. Cosmetic changes add noise for little gain *and* introduce some risk in the implementation. NetBeans has >500k lines of code, and we use `import static`sparingly. Same applies for using the `this.` prefix, we use this sparingly in those other >500k files.
   
   If you feel an urge to use `import static` for logging levels then it's better to have a single PR do this in 500k files than having 500k PRs changing each file. 
   
   Also modifying the implementation (of classes that are very sensitive to changes, since this module is probably used by everybody) and the tests at the same time is weird/risky. It's more difficult to know if the new code coming from somebody we don't know (or, as you say, _"knows too little"_) behaves the same as before. Until you gain experience I'd prefer PRs with tests only and PRs with code changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists