You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2024/10/14 21:06:33 UTC
[PR] Update pyproject.toml [beam]
liferoad opened a new pull request, #32773:
URL: https://github.com/apache/beam/pull/32773
Do not need to pin down grpcio-tools
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #32773:
URL: https://github.com/apache/beam/pull/32773#discussion_r1800260662
##########
sdks/python/pyproject.toml:
##########
@@ -21,7 +21,7 @@
requires = [
"setuptools",
"wheel>=0.36.0",
- "grpcio-tools==1.62.1",
Review Comment:
Pinned this to 1.65.5. Seem working now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32773:
URL: https://github.com/apache/beam/pull/32773#issuecomment-2412414851
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #32773:
URL: https://github.com/apache/beam/pull/32773#discussion_r1800169325
##########
sdks/python/pyproject.toml:
##########
@@ -21,7 +21,7 @@
requires = [
"setuptools",
"wheel>=0.36.0",
- "grpcio-tools==1.62.1",
Review Comment:
these are requirements for beam building environment (the environment where the whl files or sdist are built, ) ; this will not have an impact on dependency conflict you are resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #32773:
URL: https://github.com/apache/beam/pull/32773#issuecomment-2415258973
Got this message:
```
packages/apache_beam/portability/api/org/apache/beam/model/job_management/v1/beam_expansion_api_pb2_grpc.py:21: RuntimeWarning: The grpc package installed is at version 1.58.3, but the generated code in org/apache/beam/model/job_management/v1/beam_expansion_api_pb2_grpc.py depends on grpcio>=1.65.5. Please upgrade your grpc module to grpcio>=1.65.5 or downgrade your generated code using grpcio-tools<=1.58.3. This warning will become an error in 1.66.0, scheduled for release on August 6, 2024.
warnings.warn(
```
so, grpc wants to use the grpc version newer or equal than the version used to generate stubs. If we are to heed to these warnings, we should either bump the lower bound for grpc io, or revert this change (if this change didn't have intended impact).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #32773:
URL: https://github.com/apache/beam/pull/32773#issuecomment-2414321706
We might have to increase the lower bound on grpcio dependency if we keep this bump, running an experiment in https://github.com/apache/beam/pull/32784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #32773:
URL: https://github.com/apache/beam/pull/32773#discussion_r1800169325
##########
sdks/python/pyproject.toml:
##########
@@ -21,7 +21,7 @@
requires = [
"setuptools",
"wheel>=0.36.0",
- "grpcio-tools==1.62.1",
Review Comment:
these are requirements for beam building environment; this will not have an impact on dependency conflict you are resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32773:
URL: https://github.com/apache/beam/pull/32773#issuecomment-2412579414
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @shunping for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #32773:
URL: https://github.com/apache/beam/pull/32773#discussion_r1800175195
##########
sdks/python/pyproject.toml:
##########
@@ -21,7 +21,7 @@
requires = [
"setuptools",
"wheel>=0.36.0",
- "grpcio-tools==1.62.1",
Review Comment:
This affects the version of grpc compiler used to generate python stubs for grpc protos, and we cannot use the latest version due to incompatibilites.
```
RuntimeError: The grpc package installed is at version 1.65.5, but the generated code in org/apache/beam/model/pipeline/v1/metrics_pb2_grpc.py depends on grpcio>=1.66.2. Please upgrade your grpc module to grpcio>=1.66.2 or downgrade your generated code using grpcio-tools<=1.65.5.
```
I would keep it as is, we MIGHT have to bump this up due to protobuf upgrade but if we don't have to, I think we can keep as is.
We definitely cannot upgrade to grpcio>=1.66.2 while https://github.com/grpc/grpc/issues/37710 is unresolved
cc: @jrmccluskey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on PR #32773:
URL: https://github.com/apache/beam/pull/32773#issuecomment-2414312280
Merge this for now. Will check the testing status tommorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pyproject.toml [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #32773:
URL: https://github.com/apache/beam/pull/32773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org