You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/26 23:43:47 UTC

[GitHub] [beam] pabloem commented on a change in pull request #12960: [BEAM-9804] Allow user configuration of BigQuery temporary dataset

pabloem commented on a change in pull request #12960:
URL: https://github.com/apache/beam/pull/12960#discussion_r504209460



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -1096,7 +1114,8 @@ def __init__(
       test_bigquery_client=None,
       use_legacy_sql=True,
       flatten_results=True,
-      kms_key=None):
+      kms_key=None,
+      temp_dataset=None):

Review comment:
       The `BigQueryReader` is only used in the Dataflow native BigQuerySource - I don't think this is compatible, so we should probably revert changes to it.
   Let's focus on temp_dataset for _CustomBigQuerySource.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org