[GitHub] [druid] suneet-s commented on a change in pull request #9607: Remove no-op assert statement in ClientQuerySegmentWalker

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9607: Remove no-op assert statement in ClientQuerySegmentWalker
URL: https://github.com/apache/druid/pull/9607#discussion_r406589517
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java
 ##########
 @@ -274,8 +274,6 @@ private DataSource inlineIfNecessary(
           current = Iterables.getOnlyElement(current.getChildren());
         }
 
-        assert !(current instanceof QueryDataSource);
-
         current = inlineIfNecessary(current, null, subqueryRowLimitAccumulator, maxSubqueryRows, dryRun);
 
 Review comment:
   ```suggestion
           assert !(current instanceof QueryDataSource); // lgtm [java/contradictory-type-checks]
           
           current = inlineIfNecessary(current, null, subqueryRowLimitAccumulator, maxSubqueryRows, dryRun);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org