You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/21 03:41:25 UTC

Review Request 64763: Fixed compilation for python eggs when gRPC is enabled.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64763/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Kapil Arya.


Repository: mesos


Description
-------

Fixed compilation for python eggs when gRPC is enabled.


Diffs
-----

  src/python/native_common/ext_modules.py.in 47c2d24a6e5e49ad5860d96108bbb1e2eeb8dd5b 


Diff: https://reviews.apache.org/r/64763/diff/1/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Re: Review Request 64763: Fixed compilation for python eggs when gRPC is enabled.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64763/#review194356
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 21, 2017, 3:41 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64763/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 3:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed compilation for python eggs when gRPC is enabled.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/ext_modules.py.in 47c2d24a6e5e49ad5860d96108bbb1e2eeb8dd5b 
> 
> 
> Diff: https://reviews.apache.org/r/64763/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 64763: Fixed compilation for python eggs when gRPC is enabled.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64763/#review194307
-----------------------------------------------------------



PASS: Mesos patch 64763 was successfully built and tested.

Reviews applied: `['64754', '64755', '64756', '64763']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64763

- Mesos Reviewbot Windows


On Dec. 21, 2017, 3:41 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64763/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 3:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed compilation for python eggs when gRPC is enabled.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/ext_modules.py.in 47c2d24a6e5e49ad5860d96108bbb1e2eeb8dd5b 
> 
> 
> Diff: https://reviews.apache.org/r/64763/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>