You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/10 12:19:23 UTC
[GitHub] [flink] zentol opened a new pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
zentol opened a new pull request #14918:
URL: https://github.com/apache/flink/pull/14918
Various tests (mostly serializer tests) use a pattern where they have an inner class extending a test base. When the naming conventions are relaxed these are picked up as test classes, but they lack a public constructor.
Explicitly setting `@Ignore` solves the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776676720
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6cd3b9e24933db6c3113f864c6640b5d7e06a091 (Wed Feb 10 12:34:43 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776686622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198",
"triggerID" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"triggerType" : "PUSH"
}, {
"hash" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13208",
"triggerID" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ce71a30f35e944cab2e6307431911935e50c05d4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776686622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198",
"triggerID" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cd3b9e24933db6c3113f864c6640b5d7e06a091 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776686622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198",
"triggerID" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"triggerType" : "PUSH"
}, {
"hash" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13208",
"triggerID" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cd3b9e24933db6c3113f864c6640b5d7e06a091 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198)
* ce71a30f35e944cab2e6307431911935e50c05d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14918:
URL: https://github.com/apache/flink/pull/14918#discussion_r573697474
##########
File path: flink-core/src/test/java/org/apache/flink/api/common/typeutils/CompositeSerializerTest.java
##########
@@ -262,6 +263,7 @@ protected TestListCompositeSerializer createOuterSerializerWithNestedSerializers
}
}
+ @Ignore
Review comment:
nit: maybe it's easier to grasp for future readers if we add an explanation?
```suggestion
@Ignore("*TestInstance class is not a test")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776686622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cd3b9e24933db6c3113f864c6640b5d7e06a091 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14918:
URL: https://github.com/apache/flink/pull/14918#discussion_r573697474
##########
File path: flink-core/src/test/java/org/apache/flink/api/common/typeutils/CompositeSerializerTest.java
##########
@@ -262,6 +263,7 @@ protected TestListCompositeSerializer createOuterSerializerWithNestedSerializers
}
}
+ @Ignore
Review comment:
nit: maybe it's easier to grasp for future readers if we add an explanation?
```suggestion
@Ignore("*TestInstance class is not a test")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776686622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198",
"triggerID" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"triggerType" : "PUSH"
}, {
"hash" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13208",
"triggerID" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cd3b9e24933db6c3113f864c6640b5d7e06a091 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198)
* ce71a30f35e944cab2e6307431911935e50c05d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14918:
URL: https://github.com/apache/flink/pull/14918#issuecomment-776686622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198",
"triggerID" : "6cd3b9e24933db6c3113f864c6640b5d7e06a091",
"triggerType" : "PUSH"
}, {
"hash" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ce71a30f35e944cab2e6307431911935e50c05d4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cd3b9e24933db6c3113f864c6640b5d7e06a091 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13198)
* ce71a30f35e944cab2e6307431911935e50c05d4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #14918: [FLINK-21342][tests] Add '@Ignore' to *TestInstance classes
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14918:
URL: https://github.com/apache/flink/pull/14918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org