You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/02/05 00:17:48 UTC
Review Request 43228: GEODE-841:
ClientMembershipDUnitTest.testGetNotifiedClients failed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43228/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
Bugs: geode-841
https://issues.apache.org/jira/browse/geode-841
Repository: geode
Description
-------
This test threw an exception when it received a client identifier with a numeric IP address instead of a host name. On the servers these IDs are deserialized and a canonical host name is picked up from SocketCreator, but this is accessing a static cache of host names that may have been initialized during a test that turned of DNS name lookup altogether in order to avoid network delays and possible hangs.
The fix is to just clear the cache between tests.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java b55fe886b0751ec4a44960b3c4af32dd0973691a
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 46c2eb3930ec9f5656c6cf6b2d9383c26d2f1c3a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 3ee22c103b72e2f0d68e58f7ae3b37c2fa717380
gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java c0ef60dc693d6240ef7475bd27b95646a7a1785a
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 5589453abeaff980fb32a9678ae9a03faaf973d3
gemfire-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java d238dcdbd491c3c12d41d24c79b242837a664ca8
Diff: https://reviews.apache.org/r/43228/diff/
Testing
-------
precheckin testing is in progress
Thanks,
Bruce Schuchardt
Re: Review Request 43228: GEODE-841:
ClientMembershipDUnitTest.testGetNotifiedClients failed
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43228/#review118061
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Feb. 4, 2016, 11:17 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43228/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 11:17 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: geode-841
> https://issues.apache.org/jira/browse/geode-841
>
>
> Repository: geode
>
>
> Description
> -------
>
> This test threw an exception when it received a client identifier with a numeric IP address instead of a host name. On the servers these IDs are deserialized and a canonical host name is picked up from SocketCreator, but this is accessing a static cache of host names that may have been initialized during a test that turned of DNS name lookup altogether in order to avoid network delays and possible hangs.
>
> The fix is to just clear the cache between tests.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/LonerDistributionManager.java b55fe886b0751ec4a44960b3c4af32dd0973691a
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java 46c2eb3930ec9f5656c6cf6b2d9383c26d2f1c3a
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java 3ee22c103b72e2f0d68e58f7ae3b37c2fa717380
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/ParentLocalizedStrings.java c0ef60dc693d6240ef7475bd27b95646a7a1785a
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java 5589453abeaff980fb32a9678ae9a03faaf973d3
> gemfire-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java d238dcdbd491c3c12d41d24c79b242837a664ca8
>
> Diff: https://reviews.apache.org/r/43228/diff/
>
>
> Testing
> -------
>
> precheckin testing is in progress
>
>
> Thanks,
>
> Bruce Schuchardt
>
>