Re: [PR] HIVE-28998: Support Iceberg REST Catalog without authentication [hive]

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #5870:
URL: https://github.com/apache/hive/pull/5870#discussion_r2147021122


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1867,7 +1867,7 @@ public enum ConfVars {
             " positive value will be used as-is."
     ),
     ICEBERG_CATALOG_SERVLET_AUTH("metastore.iceberg.catalog.servlet.auth",
-        "hive.metastore.iceberg.catalog.servlet.auth", "jwt", new StringSetValidator("simple", "jwt"),
+        "hive.metastore.iceberg.catalog.servlet.auth", "jwt", new StringSetValidator("none", "simple", "jwt"),

Review Comment:
   That comes from `PROPERTIES_SERVLET_AUTH` - another servlet, but I don't understand why can't we have 1 generic config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org