You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/07 16:13:19 UTC
[GitHub] [incubator-nuttx-apps] michallenc opened a new pull request #1049: examples/serialrx: implement option to print string characters
michallenc opened a new pull request #1049:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1049
## Summary
The option CONFIG_EXAMPLES_SERIALRX_PRINTSTR was available in the configuration but was not implemented in the source code. This commit implements the option.
## Impact
Application only.
## Testing
Basic tests (receiving data over UART and printing them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] michallenc commented on a change in pull request #1049: examples/serialrx: implement option to print string characters
Posted by GitBox <gi...@apache.org>.
michallenc commented on a change in pull request #1049:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1049#discussion_r821025289
##########
File path: examples/serialrx/serialrx_main.c
##########
@@ -175,7 +175,14 @@ int main(int argc, FAR char *argv[])
}
fflush(stdout);
-#endif /* Kamal */
+#elif defined(CONFIG_EXAMPLES_SERIALRX_PRINTSTR)
+ for (int i = 0; i < (int)n; i++)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1049: examples/serialrx: implement option to print string characters
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1049:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1049#discussion_r820949279
##########
File path: examples/serialrx/serialrx_main.c
##########
@@ -175,7 +175,14 @@ int main(int argc, FAR char *argv[])
}
fflush(stdout);
-#endif /* Kamal */
+#elif defined(CONFIG_EXAMPLES_SERIALRX_PRINTSTR)
+ for (int i = 0; i < (int)n; i++)
Review comment:
need avoid the syntax not exist in c89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1049: examples/serialrx: implement option to print string characters
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1049:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org