You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2017/12/06 18:13:48 UTC

Review Request 64386: Windows: Enabled docker health checks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64386/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
-------

The network health checks called `curl` and then executed `setns` to
enter to container network namespace, which did not work on Windows.
To do the equivalent, Windows nows calls `docker run` with powershell's
`curl` equivalent (`Invoke-WebRequest`) and uses the
`network=container:<ID>` flag to enter the container's namespace.


Diffs
-----

  src/checks/checker.hpp 93502270f31e80c5f7c94b5b456625e9cdea1837 
  src/checks/checker.cpp fff0aac504b4283a210f936e00c977fa60d88b3d 
  src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 
  src/checks/checker_process.cpp 496bd41811a1984e905c851b5e990495517c17b8 
  src/checks/health_checker.hpp 019fbd791f250ecc28ff59d779f90e7ccbf0c685 
  src/checks/health_checker.cpp eaf9a18817eeeff7c29c7a4b9d1b183f398760a3 
  src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f 
  src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 


Diff: https://reviews.apache.org/r/64386/diff/1/


Testing
-------


Thanks,

Akash Gupta