You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/22 12:20:37 UTC
[GitHub] [skywalking] liuzhiguo630 opened a new issue #7157: Query trace should sort by startTime to reduce VNode
liuzhiguo630 opened a new issue #7157:
URL: https://github.com/apache/skywalking/issues/7157
I found lot of VNode in trace, but they are exists in storage, just limit by query size:
https://github.com/apache/skywalking/blob/1bc69370bfcd3891b0726c219e1ae39b92d8f894/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/TraceQueryEsDAO.java#L166
So I add `sourceBuilder.sort(SegmentRecord.START_TIME, SortOrder.ASC);` in `queryByTraceId`, VNode are all disappeared. if trace's size over limit, tail of the trace will not shown, not head or middle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liuzhiguo630 commented on issue #7157: Query trace should sort by startTime to reduce VNode
Posted by GitBox <gi...@apache.org>.
liuzhiguo630 commented on issue #7157:
URL: https://github.com/apache/skywalking/issues/7157#issuecomment-866014560
> I am not sure what do you mean adding a start_time sort could help.
Sure, because you haven't really use Skywalking in real world. I do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7157: Query trace should sort by startTime to reduce VNode
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7157:
URL: https://github.com/apache/skywalking/issues/7157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7157: Query trace should sort by startTime to reduce VNode
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7157:
URL: https://github.com/apache/skywalking/issues/7157#issuecomment-865980390
I am not sure what do you mean adding a start_time sort could help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7157: Query trace should sort by startTime to reduce VNode
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7157:
URL: https://github.com/apache/skywalking/issues/7157#issuecomment-866017053
> > I am not sure what do you mean adding a start_time sort could help.
>
> Sure, because you haven't really use Skywalking in real world. I do.
If this is your attitude to respond to a question, I can't see why you bother to talk with a community. This issue will be locked forever. Once you do this again, we will check across for your behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org